[SoC 2009 - Accepted] Unified Samples Framework & Browser

Threads related to Google Summer of Code
User avatar
Noman
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 714
Joined: Mon Jan 31, 2005 7:21 pm
Location: Israel
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by Noman » Wed Dec 30, 2009 5:25 pm

omniter wrote:Good stuff, Noman! :D Though, are you sure it's a good idea to remove the GUI sample? We don't want people to get the wrong idea about the tray system being used to "replace" CEGUI. It's not a full GUI system.
The OGRE team decided to drop CEGUI as a dependency for ogre starting with 1.7... I'm not sure if a CEGUI sample is needed if this is the case.

By the way, I was running OpenGL most of the time, and when I switched to directx i noticed that stencil shadows stopped working properly. Can anyone confirm this?
0 x

User avatar
boyamer
Orc
Posts: 459
Joined: Sat Jan 24, 2009 11:16 am
Location: Italy

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by boyamer » Fri Jan 01, 2010 2:40 pm

Yep,me!! Stencil shadows doesn't work at all,this is how they look

Image
0 x

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Sat Jan 02, 2010 5:03 am

This is true for me as well. Also, what's that new panel that's in the center of every sample now? It's terribly distracting. Why not put it in the details panel that already exists?
0 x

User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by jacmoe » Sat Jan 02, 2010 5:20 am

You have to teach them, Omniter. :)
I bet it's Assaf.
0 x
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Sat Jan 02, 2010 5:23 am

I'll fix it if necessary. I just wanted to check if it was intended to be that way for a good reason. If there are no objections, can I merge it into the details panel?
0 x

User avatar
sinbad
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 19265
Joined: Sun Oct 06, 2002 11:19 pm
Location: Guernsey, Channel Islands
x 2
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by sinbad » Mon Jan 04, 2010 3:47 pm

The new trays certainly don't replace CEGui, but we've decided nto to include it in our dependencies anymore so that means no specific GUI demo. CEGui itself has demos that people can use & test on Ogre so that's a better place for them anyway.

The new panel is for Nir's RTSS, and yeah I hid it away in my Terrain sample too. It can probably be merged with the detail panel that is only displayed on demand.

And yeah, Dx9's stencil shadows appear to be broken right now, GL's are fine. Not sure when that happened, unfortunately we were without a stencil shadow demo for a while so no-one was checking it. I'll put it on the buglist.
0 x

User avatar
Noman
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 714
Joined: Mon Jan 31, 2005 7:21 pm
Location: Israel
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by Noman » Mon Jan 04, 2010 4:12 pm

I hope to be able to have a closer look at it in the coming days. I'm pretty backed up until the end of the month (exam period) but I'll hopefully find a few hours to have a look.
0 x

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Mon Jan 04, 2010 9:01 pm

Merged. :D That is much better.
0 x

User avatar
sinbad
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 19265
Joined: Sun Oct 06, 2002 11:19 pm
Location: Guernsey, Channel Islands
x 2
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by sinbad » Tue Jan 05, 2010 4:24 pm

Normally OT, but since it was raised here: Dx9 stencil shadows are now fixed in 1.7.
0 x

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Tue Jan 05, 2010 4:54 pm

Hoorah! :D
0 x

User avatar
xadhoom
Minaton
Posts: 973
Joined: Fri Dec 28, 2007 4:35 pm
Location: Germany

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by xadhoom » Wed Jan 06, 2010 12:45 am

Is there a specific reason why the VolumeTex demo camera does not have a fixed yaw axis?

Code: Select all

mCamera->setFixedYawAxis(false);
This leads to a roll effect when looking around...

Also I´m not sure if the current sliders have any effect on the texture (at least its hardly visible).

xad
0 x

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Wed Jan 06, 2010 1:56 am

I didn't write that sample, but my guess is that the author intended for the yaw axis to be unfixed. It provides a spacey feeling, which works pretty well for this sample. Also, the sliders have a very noticeable effect on the textures here. I'm not sure why they do not at your end, xad. :?
0 x

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Wed Jan 06, 2010 9:47 am

So today, I cleaned up the GUI in some samples, fixed a bug, and I also added a new method, SdkSample::setDragLook. Before, you had to copy and paste about 40 or so lines of code to get drag-look working properly. Now, you just have to call setDragLook(true). The reason I didn't make this a third camera style is because 1) it is essentially just free-look, with a condition, and 2) it involves the cursor, and I didn't want SdkCameraMan to depend on SdkTrays.
0 x

User avatar
xadhoom
Minaton
Posts: 973
Joined: Fri Dec 28, 2007 4:35 pm
Location: Germany

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by xadhoom » Wed Jan 06, 2010 10:28 am

omniter wrote:I didn't write that sample, but my guess is that the author intended for the yaw axis to be unfixed. It provides a spacey feeling, which works pretty well for this sample. Also, the sliders have a very noticeable effect on the textures here. I'm not sure why they do not at your end, xad. :?
Hi omniter!

You are right, the slider do have an effect. Yesterday they didn´t and I figured out why:
- start Sample Browser
- start VolumeTex sample (everything works fine)
- press escape and stop the sample
- start VolumeTex sample again (the slider have no visible effect)

It seems to be related to improper cleanup as you raised in the developer forum generally.

Btw: I recommend to fix the yaw axis. Especially because of the skybox the effect is a bit weird.

xad
0 x

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Wed Jan 06, 2010 10:58 am

Fixed and fixed. :)
TexturePtr::setNull does not clean up the dynamic texture. Use TextureManager::remove.
0 x

User avatar
boyamer
Orc
Posts: 459
Joined: Sat Jan 24, 2009 11:16 am
Location: Italy

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by boyamer » Sun Jan 10, 2010 12:31 pm

Just to make note,Old TV compositor doesn't look well on OpenGL render system,please check the compositor sample..
0 x

User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by jacmoe » Mon Jan 11, 2010 2:32 am

Just wanted to say that I've just ported the OgreAppWizard to using SdkTrays and SdkCameraMan, and it was both enjoyable and easy.
Much cleaner and meaner now.
Thanks to you, Omniter, for creating a well-written, well-documented framework!
Thanks a lot. :)
0 x
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Mon Jan 11, 2010 2:37 am

Ahahaha :lol: Thanks, and you're welcome. :D
0 x

User avatar
spacegaier
OGRE Team Member
OGRE Team Member
Posts: 4293
Joined: Mon Feb 04, 2008 2:02 pm
Location: Germany
x 2
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by spacegaier » Mon Jan 11, 2010 9:28 pm

WTF!!! Thanks to jacmoe I just setup Ogre 1.7 on my PC and just wanted to have a quick look at your SampleBrowser, but then...








:shock:








:shock: :shock:







:shock: :shock: :shock:








:shock: :shock: :shock: :shock:








:shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock: :shock:





...BOUM. It blew me away. That thing is damn gorgeous!!! A really great contribution to the SDK! Thank you very much, Omniter, for making this great experience happen :D
0 x
Ogre Admin [Admin, Dev, PR, Finance, Wiki, etc.] | BasicOgreFramework | AdvancedOgreFramework
Don't know what to do in your spare time? Help the Ogre wiki grow! Or squash a bug...

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Mon Jan 11, 2010 9:33 pm

Spammer. :lol:
0 x

User avatar
spacegaier
OGRE Team Member
OGRE Team Member
Posts: 4293
Joined: Mon Feb 04, 2008 2:02 pm
Location: Germany
x 2
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by spacegaier » Mon Jan 11, 2010 9:36 pm

Spammer? Well, yes, but that was really my first reaction. I've seen pictures and videos of it before, but actually getting your hands on it, is way better. As I said, you've done a really great job here and saying this is even worth using my 1.000th post in this forum here :) .
0 x
Ogre Admin [Admin, Dev, PR, Finance, Wiki, etc.] | BasicOgreFramework | AdvancedOgreFramework
Don't know what to do in your spare time? Help the Ogre wiki grow! Or squash a bug...

User avatar
omniter
OGRE Contributor
OGRE Contributor
Posts: 424
Joined: Thu Mar 19, 2009 8:08 am
Location: Canada

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by omniter » Mon Jan 11, 2010 9:42 pm

Woa! Congrats! And I'm honoured. I still have a ways to go though. :D
0 x

User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by jacmoe » Thu Jan 14, 2010 8:47 pm

I've found a bug in sdkCameraMan - should I post it here? :)

I think I'll do.

The problem is that the acceleration is hard-coded.
It works fine when setting the top speed higher than 20, but fails if we have a topspeed of 15.0f.
It's needed, because speeds over 20 is too fast for 1 unit == 1 metre scenes.
A speed below 20 results in the camera being stuck, or very difficult to persuade to move.

Could it be scaled?

Like accel value == mTopSpeed / 7.5f. (20 with mTopSpeed of 150)
And the velocity modifer == mTopSpeed / 15.0f. (10 with mTopSpeed of 150)

Those values were chosen based on the default mTopSpeed of 150.0f.

I think that's what the issue is - haven't recompiled with different settings.
0 x
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.

User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by jacmoe » Thu Jan 14, 2010 8:57 pm

Of course, providing a means of setting the scaling factor would be a nice feature.
It shouldn't be hardcoded.
0 x
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.

User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
Contact:

Re: [SoC 2009 - Accepted] Unified Samples Framework & Browser

Post by jacmoe » Thu Jan 14, 2010 9:57 pm

Fixed:

Code: Select all

				// keep camera velocity below top speed and above zero
				if (mVelocity.squaredLength() > topSpeed * topSpeed)
				{
					mVelocity.normalise();
					mVelocity *= topSpeed;
				}
				else if (mVelocity.squaredLength() < 0.0000001) mVelocity = Ogre::Vector3::ZERO;
0.1 is way too high a value for an EPSILON at low speeds - changed it to 0.0000001, and it works! :)
0 x
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.

Post Reply