[GSoC 2012] Volume Rendering with LOD aimed at terrain

Threads related to Google Summer of Code
Post Reply
User avatar
Mattan Furst
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 260
Joined: Tue Jan 01, 2008 11:28 am
Location: Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Mattan Furst » Tue Aug 21, 2012 8:13 pm

@PhilipLB

Just to make sure we are all on the same page.
both Assaf, CABAListic and I want the your GSoC project to be merged to v1-9. Just as you did on https://bitbucket.org/philiplb/ogrevolumeterrain2/.
now it only needs to be pushed to the main ogre source control on https://bitbucket.org/sinbad/ogre (also on the v1-9 branch) .
I already gave you writing permissions to https://bitbucket.org/sinbad/ogre about a month ago (as discussed in earlier posts).

would you like to do the honors?

edit:
p.s
I thought this would be the fun part
0 x
it's turtles all the way down

PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by PhilipLB » Tue Aug 21, 2012 8:15 pm

With pleasure, right now. :)
0 x
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.

PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by PhilipLB » Tue Aug 21, 2012 10:10 pm

Done! :D
0 x
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.

User avatar
duststorm
Minaton
Posts: 921
Joined: Sat Jul 31, 2010 6:29 pm
Location: Belgium
Contact:

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by duststorm » Tue Aug 21, 2012 10:14 pm

nice :)
0 x
Developer @ MakeHuman.org

CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
Contact:

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by CABAListic » Tue Aug 21, 2012 10:17 pm

Excellent! Now that it's in v1-9, it's easy to get it into v2-0 and default, too. It'll just get picked up once we do the next forward merge.
0 x

User avatar
Mattan Furst
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 260
Joined: Tue Jan 01, 2008 11:28 am
Location: Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Mattan Furst » Tue Aug 21, 2012 10:27 pm

0 x
it's turtles all the way down

User avatar
Assaf Raman
OGRE Team Member
OGRE Team Member
Posts: 3092
Joined: Tue Apr 11, 2006 3:58 pm
Location: TLV, Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Assaf Raman » Wed Aug 22, 2012 12:20 am

I have issues in the d3d11 render system after your project commit:
02:03:11: OGRE EXCEPTION(7:InternalErrorException): Unable to compile Cg program 2817628953_FS: The compile returned an error.
SGXLib_TriplanarTexturing.cg(7) : error C1008: undefined variable "normalAndFogVal"
SGXLib_TriplanarTexturing.cg(8) : error C1008: undefined variable "texScale"
SGXLib_TriplanarTexturing.cg(9) : error C1008: undefined variable "texScale"
SGXLib_TriplanarTexturing.cg(10) : error C1008: undefined variable "texScale"
in CgProgram::compileMicrocode at C:\hg_Code\ogre\d3d11_GSoc\forMerge\src\PlugIns\CgProgramManager\src/OgreCgProgramManagerDll.cpp (line 67)
Will you be able to find some time to fix this?

Also - what is going on with the EOL on your commit? Do you use the '"hgext.win32text" extension?
It led me to back-out the undo the back-up of one of my commits... Make sure you commit with the right EOL.
0 x
Watch out for my OGRE related tweets here.

User avatar
masterfalcon
OGRE Team Member
OGRE Team Member
Posts: 4270
Joined: Sun Feb 25, 2007 4:56 am
Location: Bloomington, MN
Contact:

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by masterfalcon » Wed Aug 22, 2012 12:39 am

I also saw that happening with GL as well.
0 x

User avatar
Assaf Raman
OGRE Team Member
OGRE Team Member
Posts: 3092
Joined: Tue Apr 11, 2006 3:58 pm
Location: TLV, Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Assaf Raman » Wed Aug 22, 2012 12:42 am

Well, parameters are just missing from SGXLib_TriplanarTexturing.cg, I don't understand how it worked before the commit, this smells like a bad commit...
0 x
Watch out for my OGRE related tweets here.

PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by PhilipLB » Wed Aug 22, 2012 9:07 am

Will be fixed asap. :)
0 x
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.

User avatar
Mattan Furst
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 260
Joined: Tue Jan 01, 2008 11:28 am
Location: Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Mattan Furst » Wed Aug 22, 2012 2:53 pm

Parameters are fixed temporarily including a small problem with parameter creation problem in the tri-planar shader
0 x
it's turtles all the way down

PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by PhilipLB » Wed Aug 22, 2012 3:03 pm

Thx, I'll have a look at it anyway what the problem was / fix the temp. solution.

I've seen, that there are a bunch of warning-fixes done, like changing

Code: Select all

virtual const Real getValue(const Vector3 &position) const = 0;
to

Code: Select all

virtual Real getValue(const Vector3 &position) const = 0;
What warning was that? :) Isn't it ok to return const stuff?
0 x
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.

User avatar
Assaf Raman
OGRE Team Member
OGRE Team Member
Posts: 3092
Joined: Tue Apr 11, 2006 3:58 pm
Location: TLV, Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Assaf Raman » Wed Aug 22, 2012 3:11 pm

I don't know
0 x
Watch out for my OGRE related tweets here.

CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
Contact:

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by CABAListic » Wed Aug 22, 2012 3:14 pm

No, apparently it's not ok for POD types, because as return values they are already treated as const or something like that. Which I think is a pain in the ass, because it is ok and legitimate to do for non-POD types, and I hate these kinds of inconsistencies.
0 x

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by FlorianGeorge » Wed Aug 22, 2012 3:21 pm

http://stackoverflow.com/questions/1134 ... eturn-type

I personally don't think it hurts to add the const to keep it consistently, and I don't get any warnings for it in Visual C++, but i guess the gcc community would get annoyed by the warnings.
0 x

PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by PhilipLB » Wed Aug 22, 2012 3:31 pm

Interesting, thx.

(Cpp is such a beast...)
0 x
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.

TheSHEEEP
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 972
Joined: Mon Jun 02, 2008 6:52 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by TheSHEEEP » Wed Aug 22, 2012 3:58 pm

It's called diva :D
0 x
My site! - Have a look :)
Also on Twitter - extra fluffy

bstone
OGRE Expert User
OGRE Expert User
Posts: 1920
Joined: Sun Feb 19, 2012 9:24 pm
Location: Russia

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by bstone » Wed Aug 22, 2012 7:43 pm

Adding const to things returned by value as opposed to references and pointers makes little sense since you give the value away and don't really care if it's modified or not. It doesn't matter if it's a built-in type or a user defined one. Furthermore, once you get into rvalue refs that habit will be harmful for types supporting move copy/construction semantics and will bite you in the back once in a while :D
0 x

CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
Contact:

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by CABAListic » Wed Aug 22, 2012 9:10 pm

You do care because it prevents certain mistakes, e.g.

Code: Select all

if (someFunc() = 42)
{
  // ...
}
Now, for POD types like ints this is already illegal code because they are already treated as const rvalue. That's why GCC gives you a warning if you declare someFunc as const int - the const qualifier is redundant. But if it returns a class type, the const is not redundant and can prevent similar mistakes. So unless you know you want different behaviour, adding const to non-POD return values is good practice, imho.
0 x

User avatar
Mattan Furst
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 260
Joined: Tue Jan 01, 2008 11:28 am
Location: Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Mattan Furst » Wed Aug 22, 2012 9:19 pm

Hello Philip,

I just talked to Assaf. One of your check-ins "3760 (e09c55ac19a0) Volume Rendering: added volume media" contains a large media file called samples\media\volumeTerrain\volumeTerrainBig.zip. This file is to big for Ogre's repository taste.

I am currently researching ways to strip the file from Ogre.

Do not attempt to delete it or change it. That will not remove it from the repository. it will just add to it.
0 x
it's turtles all the way down

User avatar
Assaf Raman
OGRE Team Member
OGRE Team Member
Posts: 3092
Joined: Tue Apr 11, 2006 3:58 pm
Location: TLV, Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Assaf Raman » Wed Aug 22, 2012 9:33 pm

0 x
Watch out for my OGRE related tweets here.

User avatar
Assaf Raman
OGRE Team Member
OGRE Team Member
Posts: 3092
Joined: Tue Apr 11, 2006 3:58 pm
Location: TLV, Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Assaf Raman » Wed Aug 22, 2012 9:36 pm

0 x
Watch out for my OGRE related tweets here.

User avatar
Assaf Raman
OGRE Team Member
OGRE Team Member
Posts: 3092
Joined: Tue Apr 11, 2006 3:58 pm
Location: TLV, Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Assaf Raman » Wed Aug 22, 2012 9:41 pm

0 x
Watch out for my OGRE related tweets here.

User avatar
Mattan Furst
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 260
Joined: Tue Jan 01, 2008 11:28 am
Location: Israel

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by Mattan Furst » Wed Aug 22, 2012 10:11 pm

Assaf

I wasn't aware of the HisteditExtension extension. But how ever it is used I doubt its that easy. from what I've read mercurial is not built for these sort of things. if you remove something from the repository it changes the entire history and the repository becomes hard to merge. and even if you do that you need to make sure it doesn't come back in from other forks.
0 x
it's turtles all the way down

PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin

Re: [GSoC 2012] Volume Rendering with LOD aimed at terrain

Post by PhilipLB » Wed Aug 22, 2012 10:34 pm

This is the 3D texture with the volume data of the terrain. What to do without it? It's 256x256x256. I could create one with 128x128x128 maybe, but then the terrain has far less details. But this .dds would be 8MB then.
But I'd suggest to just stay with the big file now if it isn't easy to be removed. Sorry to have not used 128^3 from the beginning on. :(
0 x
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.

Post Reply