Drop the "Ogre::SceneType" enum

Minor issues with the Ogre API that can be trivial to fix
Post Reply
User avatar
only_a_ptr
Halfling
Posts: 62
Joined: Sun Apr 26, 2009 8:43 pm

Drop the "Ogre::SceneType" enum

Post by only_a_ptr » Fri Sep 15, 2017 11:49 am

Currently there are 2 methods to choose scene manager:

The intent of the 'scene type flags' (http://www.ogre3d.org/docs/api/1.9/grou ... 969b9af914) was to let OGRE select a suitable scenemanager plugin. However, I think this concept failed because Ogre only provides 4 scenemanager types and all have issues with labeling: My conclusion is that 'scene type' flags don't help the user to pick up scenemanager as intended. They might have been helpful if multiple addon scene managers were created, but apparently that never happened and seems unlikely to happen in the future. Therefore I suggest to remove the 'scene type' flags and respective 'createSceneManager' function - in favor of the "specify name directly" method.

The reason I started this research was a situation in a project I maintain - we disabled building OctreeSceneManager by accident and I was baffled that the game is still running without any scenemanager plugin. I thought OctreeSceneManager was the default one. Link to my original rant in our issue tracker: https://github.com/RigsOfRods/rigs-of-rods/issues/1379
0 x
Rigs of Rods is alive and kicking!

User avatar
Zonder
Gargoyle
Posts: 1076
Joined: Mon Aug 04, 2008 7:51 pm
Location: Manchester - England

Re: Drop the "Ogre::SceneType" enum

Post by Zonder » Fri Sep 15, 2017 3:16 pm

I think this is one of those things that just never happened / needed. And I think (trying to remember back) it was something introduced in the very early life of ogre pretty sure it was in 0.4 but unsure earlier as I didn't follow as closly then.
0 x
There are 10 types of people in the world: Those who understand binary, and those who don't...
My Blog - http://www.This post is suspected as SPAM! If you feel otherwise contact a moderator.

paroj
OGRE Team Member
OGRE Team Member
Posts: 339
Joined: Sun Mar 30, 2014 2:51 pm
Contact:

Re: Drop the "Ogre::SceneType" enum

Post by paroj » Tue Oct 24, 2017 10:37 am

please directly open an issue next time: https://github.com/OGRECave/ogre/issues/550
0 x

User avatar
only_a_ptr
Halfling
Posts: 62
Joined: Sun Apr 26, 2009 8:43 pm

Re: Drop the "Ogre::SceneType" enum

Post by only_a_ptr » Mon Nov 13, 2017 5:12 pm

I've just read about `SceneType` being removed in the dev blog: http://www.ogre3d.org/2017/11/07/ogre-ecosystem-roundup - and I wondered if it's a response to my post.
paroj wrote:
Tue Oct 24, 2017 10:37 am
please directly open an issue next time: https://github.com/OGRECave/ogre/issues/550
Oh, I didn't think I could be straightforward like that... allright then, I'll log an issue next time, thanks!
0 x
Rigs of Rods is alive and kicking!

Post Reply