Bone does not remove tag points

Minor issues with the Ogre API that can be trivial to fix
Post Reply
Frankincense
Kobold
Posts: 33
Joined: Mon May 05, 2014 5:36 pm
x 3

Bone does not remove tag points

Post by Frankincense »

It looks like Bone::removeTagPoint( TagPoint *child ) attempts to remove TagPoints from its mChildren node list instead of its mTagPointChildren list -
https://github.com/OGRECave/ogre-next/b ... e.cpp#L192

I believe this:

Code: Select all

if( child->mParentIndex < mChildren.size() )
should be:

Code: Select all

if( child->mParentIndex < mTagPointChildren.size() )
Happy to be corrected though!
User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 5292
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 1278
Contact:

Re: Bone does not remove tag points

Post by dark_sylinc »

Well spotted!

Classic copy-paste error. Fixed in all branches.

Thanks.
Cheers!
Post Reply