[2.1] Bug when re-using cull data (V1 Renderables get added twice or more!)
-
- OGRE Expert User
- Posts: 1227
- Joined: Thu Dec 11, 2008 7:56 pm
- Location: Bristol, UK
- x 157
[2.1] Bug when re-using cull data (V1 Renderables get added twice or more!)
When using 're-use cull data' SceneManager::_cullPhase01 is not called and so the render queue is not cleared. However V1 renderables are added to the render queue in SceneManager::_renderPhase02, and so the same renderable ends up begin added twice or more.
Is there any reason one V1 renderables are added during _renderPhase02? It was not immediately obvious to me
Is there any reason one V1 renderables are added during _renderPhase02? It was not immediately obvious to me
- dark_sylinc
- OGRE Team Member
- Posts: 5296
- Joined: Sat Jul 21, 2007 4:55 pm
- Location: Buenos Aires, Argentina
- x 1278
- Contact:
Re: [2.1] Bug when re-using cull data (V1 Renderables get added twice or more!)
This was a PR, so you may have to ask the one who submitted it (maybe was it xrgo?)
Could be most likely an oversight. The only issue with v1 objects is that they rely in _updateRenderQueue to add themselves, and they can do whatever they want in there (eg. fill a buffer with required data that is view dependent). Normal Entities are ok, but other v1 objects may be fine or not.
Could be most likely an oversight. The only issue with v1 objects is that they rely in _updateRenderQueue to add themselves, and they can do whatever they want in there (eg. fill a buffer with required data that is view dependent). Normal Entities are ok, but other v1 objects may be fine or not.
-
- OGRE Expert User
- Posts: 1148
- Joined: Sat Jul 06, 2013 10:59 pm
- Location: Chile
- x 168
Re: [2.1] Bug when re-using cull data (V1 Renderables get added twice or more!)
TaaTT4 if I recall correctlydark_sylinc wrote: ↑Fri Apr 13, 2018 9:39 pm This was a PR, so you may have to ask the one who submitted it (maybe was it xrgo?)
-
- OGRE Expert User
- Posts: 1227
- Joined: Thu Dec 11, 2008 7:56 pm
- Location: Bristol, UK
- x 157
Re: [2.1] Bug when re-using cull data (V1 Renderables get added twice or more!)
Grumble! I had forgotten about that. Billboards are certainly an issue here. Not going to be as easy to fix as I thought.dark_sylinc wrote: ↑Fri Apr 13, 2018 9:39 pm The only issue with v1 objects is that they rely in _updateRenderQueue to add themselves, and they can do whatever they want in there (eg. fill a buffer with required data that is view dependent)
Thanks for your replies, but just be cheaper to re-enable culling for both eyes!
- TaaTT4
- OGRE Contributor
- Posts: 267
- Joined: Wed Apr 23, 2014 3:49 pm
- Location: Bologna, Italy
- x 75
- Contact:
Re: [2.1] Bug when re-using cull data (V1 Renderables get added twice or more!)
Did someone invoke me?xrgo wrote: ↑Fri Apr 13, 2018 11:05 pmTaaTT4 if I recall correctlydark_sylinc wrote: ↑Fri Apr 13, 2018 9:39 pm This was a PR, so you may have to ask the one who submitted it (maybe was it xrgo?)
Yep, I'me the guy behind that PR.
Honestly, I didn't test the reuse cull data feature with V1 entities because I use just items.
Senior programmer at 505 Games; former senior engine programmer at Sandbox Games
Worked on: Racecraft Esport — Racecraft Coin-Op, Victory: The Age of Racing