[2.1] Inconsistent include folder structure

Discussion area about developing with Ogre2 branches (2.1, 2.2 and beyond)
Post Reply
chchwy
Gnoblar
Posts: 24
Joined: Fri Feb 10, 2017 1:40 am
x 8

[2.1] Inconsistent include folder structure

Post by chchwy » Fri Feb 22, 2019 7:20 am

I tried to use OgreParallaxCorrectedCubemap in my project but got an error in the following line:

Code: Select all

#include "OgreParallaxCorrectedCubemap.h"
Error message is: Cannot open include file: 'Cubemaps/OgreCubemapProbe.h': No such file or directory

I dug into it a little bit and found out the include folder of HlmsPbs project is different from the include folder in SDK.

In the Hlms Pbs project, it has Cubemaps and InstantRadiosity subfolders:
Image

But in the SDK, everything is in a single folder:
Image

That's why I got an error from #include "Cubemaps/OgreCubemapProbe.h" because there is no Cubemaps subfolder anymore.

I know I can point the include paths directly to HlmsPbs project, but it makes the SDK somehow useless. :?
0 x

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 4066
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 228
Contact:

Re: [2.1] Inconsistent include folder structure

Post by dark_sylinc » Fri Feb 22, 2019 5:01 pm

See Build issue/bug post. Solutions are still welcome.

The SDK folder structure should follow that of the source code.
0 x

chchwy
Gnoblar
Posts: 24
Joined: Fri Feb 10, 2017 1:40 am
x 8

Re: [2.1] Inconsistent include folder structure

Post by chchwy » Tue Feb 26, 2019 12:22 am

I see. thanks for your reply. :)
0 x

al2950
OGRE Expert User
OGRE Expert User
Posts: 1200
Joined: Thu Dec 11, 2008 7:56 pm
Location: Bristol, UK
x 76

Re: [2.1] Inconsistent include folder structure

Post by al2950 » Tue Feb 26, 2019 9:09 pm

FYI, and added a fix so it keeps the folder structure, although you still have to explicitly include the HLMS/common folder in your projects. However I think the PR only got merged into 2.2. I did not realise it was much of an issue in 2.1. See here for the PR
0 x

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 4066
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 228
Contact:

Re: [2.1] Inconsistent include folder structure

Post by dark_sylinc » Wed Feb 27, 2019 4:05 am

Backported.

Thanks. I forgot you fixed it for 2.2
1 x

Post Reply