Page 1 of 1

[2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Posted: Fri Feb 22, 2019 3:03 pm
by rujialiu
Hi!

With a material with FLAG_SPERATE_DIFFUSE_FRESNEL, if hlms piece BRDF_EnvMap is used, shader will fail to compile because piece getDiffuseFresnelWithRoughness used NdotL, but the definition of NdotL is commented at the beginning of @piece BRDF_EnvMap. It looks like uncommenting that line will not cause other problems?

Thanks!

Re: [2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Posted: Fri Feb 22, 2019 5:00 pm
by dark_sylinc
Hi!

I remember I commented it because I saw NdotL was not being used. Obviously, I saw wrong.

Thanks for the report!

Re: [2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Posted: Sun Feb 24, 2019 3:21 am
by rujialiu
dark_sylinc wrote:
Fri Feb 22, 2019 5:00 pm
Thanks for the report!
Thanks for the fix!