[2.1] Something weird with Direct3D 11 rendersystem

Discussion area about developing with Ogre2 branches (2.1, 2.2 and beyond)
Post Reply
chchwy
Gnoblar
Posts: 23
Joined: Fri Feb 10, 2017 1:40 am
x 8

[2.1] Something weird with Direct3D 11 rendersystem

Post by chchwy » Mon May 13, 2019 2:33 am

I am aware of a visual artifact of Direct3D 11 rendersystem in the latest v2.1 branch.

Please see the screenshots below, it's the official PbsMaterial sample.

Direct3D 11
Image

Metal
Image

OpenGL3+
Image
0 x

chchwy
Gnoblar
Posts: 23
Joined: Fri Feb 10, 2017 1:40 am
x 8

Re: [2.1] Something weird with Direct3D 11 rendersystem

Post by chchwy » Mon May 13, 2019 4:37 am

After a bit of back and forth in the hg history, I can confirm the issue was introduced in the commit 64a18fb

The screenshot of PbsMaterial sample at commit 64a18fb

Image
64a18fb
[D3D11] Fixed conversion from D3D11 pitch (in bytes) to Ogre pitch (in pixels). Credits to Lior Lahav for noting.
previous commit 206dc06
Image
206dc06
[D3D11] D3D11HardwarePixelBuffer::_unmapstaticbuffer simplified, wrong box parameter in TEX_TYPE_3D case fixed
Last edited by chchwy on Tue May 14, 2019 4:08 am, edited 1 time in total.
1 x

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 4036
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 214
Contact:

Re: [2.1] Something weird with Direct3D 11 rendersystem

Post by dark_sylinc » Mon May 13, 2019 3:19 pm

Thanks for looking into it!

I will be going away this week so I won't be around to fix it immediately. I will have to sort it out when I get back.

I have pinged Eugene who is the one who introduced this regression.

It seems his commit overrode my changes in commit 64d1f316072e.

In the meantime use that previous commit or roll the troublesome commit back (TortoiseHg -> Backout).
0 x

User avatar
Eugene
OGRE Team Member
OGRE Team Member
Posts: 183
Joined: Mon Mar 24, 2008 4:54 pm
Location: Odessa, Ukraine

Re: [2.1] Something weird with Direct3D 11 rendersystem

Post by Eugene » Sun May 19, 2019 11:01 pm

Seems that I overlooked the fact, that in v2.1 semantic of PixelBox::rowPitch was changed for compressed formats. Mea culpa.
0 x

Post Reply