Page 1 of 1
[2.1] Something weird with Direct3D 11 rendersystem
Posted: Mon May 13, 2019 2:33 am
by chchwy
I am aware of a visual artifact of Direct3D 11 rendersystem in the latest v2.1 branch.
Please see the screenshots below, it's the official PbsMaterial sample.
Direct3D 11
Metal
OpenGL3+
Re: [2.1] Something weird with Direct3D 11 rendersystem
Posted: Mon May 13, 2019 4:37 am
by chchwy
After a bit of back and forth in the hg history, I can confirm the issue was introduced in the commit 64a18fb
The screenshot of PbsMaterial sample at commit 64a18fb
64a18fb
[D3D11] Fixed conversion from D3D11 pitch (in bytes) to Ogre pitch (in pixels). Credits to Lior Lahav for noting.
previous commit 206dc06
206dc06
[D3D11] D3D11HardwarePixelBuffer::_unmapstaticbuffer simplified, wrong box parameter in TEX_TYPE_3D case fixed
Re: [2.1] Something weird with Direct3D 11 rendersystem
Posted: Mon May 13, 2019 3:19 pm
by dark_sylinc
Thanks for looking into it!
I will be going away this week so I won't be around to fix it immediately. I will have to sort it out when I get back.
I have pinged Eugene who is the one who introduced this regression.
It seems his commit overrode my changes in commit 64d1f316072e.
In the meantime use that previous commit or roll the troublesome commit back (TortoiseHg -> Backout).
Re: [2.1] Something weird with Direct3D 11 rendersystem
Posted: Sun May 19, 2019 11:01 pm
by Eugene
Seems that I overlooked the fact, that in v2.1 semantic of PixelBox::rowPitch was changed for compressed formats. Mea culpa.