Ogre Forums

xrgo wrote: ↑

Fri May 17, 2019 4:58 pm

rujialiu I summon you!
he helped me with that task, and prefer if he shares it.
rujia, maybe you could make a branch/fork on the official myGui repo?

Arggg. I was also helped by rujialiu, but I did say I would create a PR with my changes but have failed to do that. I am not sure my approach to the changes is the most universal, but maybe I should at least make them public. I ve put it off because it requires git, which just irritates me! Ill try and find time this weekend

al2950 wrote: ↑

Sun May 26, 2019 11:52 am

ok, so it turns out I was even lazier than I thought. I think i took rujialiu changes and made them less sensible! I would really like to sort this properly so there is 1 ogre branch in mygui, with as much shared code as possible. This will obviously take a little while, and might be too messy to actually do. in the meantime I have uploaded what I currently use for 2.2:

https://github.com/al2950/mygui/tree/Ogre2.2

xrgo wrote: ↑

Tue Aug 13, 2019 9:07 pm

Now I am porting my engine to Direct3D11 and all the MyGui stuffs don't show on the objects on the scene but it shows on the main render window :S

	void MyGUIPass::execute(const Ogre::Camera *lodCameraconst)
	{
        profilingBegin();
        executeResourceTransitions();
        setRenderPassDescToCurrent();
		static_cast<MyGUI::Ogre2RenderManager*>(MyGUI::RenderManager::getInstancePtr())->render();
        profilingEnd();
	}

This was all deadcode, so if the code was fully running on Ogre 2.2 it is very likely that just removing those includes is enough to make things running again.

Ogre::TextureUsage Ogre2Texture::convertUsage(TextureUsage _usage)
	{
		if (_usage == TextureUsage::Default)
		{
			return Ogre::TU_STATIC_WRITE_ONLY;
		}
		else if (_usage == TextureUsage::RenderTarget)
		{
			return Ogre::TU_RENDERTARGET;
		}
		else if (_usage.isValue(TextureUsage::Static))
		{
			if (_usage.isValue(TextureUsage::Write))
			{
				return Ogre::TU_STATIC_WRITE_ONLY;
			}
			else
			{
				return Ogre::TU_STATIC;
			}
		}
		else if (_usage.isValue(TextureUsage::Dynamic))
		{
			if (_usage.isValue(TextureUsage::Write))
			{
				return Ogre::TU_DYNAMIC_WRITE_ONLY;
			}
			else
			{
				return Ogre::TU_DYNAMIC;
			}
		}
		else if (_usage.isValue(TextureUsage::Stream))
		{
			if (_usage.isValue(TextureUsage::Write))
			{
				return Ogre::TU_DYNAMIC_WRITE_ONLY_DISCARDABLE;
			}
			else
			{
				return Ogre::TU_DYNAMIC;
			}
		}
		return Ogre::TU_DEFAULT;
	}

Lax wrote: ↑

Tue Oct 08, 2019 9:20 pm

Hi,

This was all deadcode, so if the code was fully running on Ogre 2.2 it is very likely that just removing those includes is enough to make things running again.

Unfortunately not.

I could replace "OgreTextureManager" with "OgreTextureGpuManager" etc.

Trying to compile MyGUI I found other issues:

- Ogre::TextureUsage is also no more available:

Code: Select all

Ogre::TextureUsage Ogre2Texture::convertUsage(TextureUsage _usage)
	{
		if (_usage == TextureUsage::Default)
		{
			return Ogre::TU_STATIC_WRITE_ONLY;
		}
		else if (_usage == TextureUsage::RenderTarget)
		{
			return Ogre::TU_RENDERTARGET;
		}
		else if (_usage.isValue(TextureUsage::Static))
		{
			if (_usage.isValue(TextureUsage::Write))
			{
				return Ogre::TU_STATIC_WRITE_ONLY;
			}
			else
			{
				return Ogre::TU_STATIC;
			}
		}
		else if (_usage.isValue(TextureUsage::Dynamic))
		{
			if (_usage.isValue(TextureUsage::Write))
			{
				return Ogre::TU_DYNAMIC_WRITE_ONLY;
			}
			else
			{
				return Ogre::TU_DYNAMIC;
			}
		}
		else if (_usage.isValue(TextureUsage::Stream))
		{
			if (_usage.isValue(TextureUsage::Write))
			{
				return Ogre::TU_DYNAMIC_WRITE_ONLY_DISCARDABLE;
			}
			else
			{
				return Ogre::TU_DYNAMIC;
			}
		}
		return Ogre::TU_DEFAULT;
	}

How could that be replaced?

void Ogre2Texture::createManual(int _width, int _height, TextureUsage _usage, PixelFormat _format)
    {
        setFormat(_format);
        setUsage(_usage);
        uint32 textureFlags = 0; // Ogre::TextureFlags::PrefersLoadingFromFileAsSRGB
        if (_usage.isValue(TextureUsage::RenderTarget)) {
            textureFlags |= Ogre::TextureFlags::RenderToTexture;
        }
        // TODO: Ogre::TextureFlags::Manual

        Ogre::TextureGpuManager *textureMgr = Ogre::Root::getSingletonPtr()->getRenderSystem()->getTextureGpuManager();
        mTexture = textureMgr->createOrRetrieveTexture(
            mName,
            Ogre::GpuPageOutStrategy::Discard,
            textureFlags,
            Ogre::TextureTypes::Type2D,
            Ogre::ResourceGroupManager::
            AUTODETECT_RESOURCE_GROUP_NAME);
        
        if (mTexture) {
            mTexture->setResolution(_width, _height);
            mTexture->setPixelFormat(mPixelFormat);
        }

        if (_usage.isValue(TextureUsage::RenderTarget)) {
            textureFlags |= Ogre::TextureFlags::RenderToTexture;
            if (mTexture->getNextResidencyStatus() != Ogre::GpuResidency::Resident) {
                mTexture->_transitionTo(Ogre::GpuResidency::Resident, nullptr);
                mTexture->_setNextResidencyStatus(Ogre::GpuResidency::Resident);
            }
        }
        setDataBlockTexture(mTexture);
    }

Lax wrote: ↑

Tue Oct 08, 2019 9:20 pm

Trying to compile MyGUI I found other issues:

mSceneManager->getRenderQueue()->renderPassPrepare(false, false);
mSceneManager->getRenderQueue()->render(mSceneManager->getDestinationRenderSystem(), RENDER_QUEUE_OVERLAY, RENDER_QUEUE_OVERLAY+1, false, false);

rujialiu wrote: ↑

Wed Oct 09, 2019 2:41 am

After your code compiles, it's likely that it'll crash. That's because the with fixing issue 33, RenderQueue::frameEnded() has an assertion inside that expect every render() is followed by renderPassPrepare() AND no VaoManager::_update() is called in-between(). However, that means in MyGUI's Ogre2RenderManager::render(), you have to call renderPassPrepare before calling render(), like this:

Code: Select all

mSceneManager->getRenderQueue()->renderPassPrepare(false, false);
mSceneManager->getRenderQueue()->render(mSceneManager->getDestinationRenderSystem(), RENDER_QUEUE_OVERLAY, RENDER_QUEUE_OVERLAY+1, false, false);

That is likely breaking other codes as well. Is it intended, @dark_sylinc?

1. Call RenderSystem::beginRenderPassDescriptor
2. Call Overlays' _updateRenderQueue (i.e. in fireRenderQueueStarted). You don't need to if you don't use Overlays. But if you need to copy GPU buffers around, then this still applies.
3. Call RenderQueue::renderPassPrepare
4. Call executeRenderPassDescriptorDelayedActions (which originally was inside beginRenderPassDescriptor)
5. Call RenderQueue::render

dark_sylinc wrote: ↑

Sun Oct 20, 2019 11:50 pm

Update: I've pushed a documentation update to clarify this