More options in convertPackedColour

What it says on the tin: a place to discuss proposed new features.
Post Reply
Crashy
Google Summer of Code Student
Google Summer of Code Student
Posts: 996
Joined: Wed Jan 08, 2003 9:15 pm
Location: Lyon, France
x 20
Contact:

More options in convertPackedColour

Post by Crashy » Mon Dec 01, 2008 11:02 pm

Hi guys.
Just a little advice. yet, VertexData::convertPackedColour can only convert to ARGB and ABGR format which are used for Direct X and OpenGL. But let's say I'd port ogre on wii (;) ), where vertex colors are using the RGBA format, so VET_COLOUR, I'd get an assertion failed. And what about the VertexElement::convertColourValue which can only convert between ARGB and ABGR by swapping Blue and Red. For the moment I'd need to modify both functions to handle it correctly.

It may be a little bit more generic if it could handle at least the RGBA format.

Just my 2 cents ;)
0 x
Follow la Moustache on Twitter or on Facebook
Image

User avatar
sinbad
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 19265
Joined: Sun Oct 06, 2002 11:19 pm
Location: Guernsey, Channel Islands
x 2
Contact:

Post by sinbad » Tue Dec 02, 2008 1:28 pm

We'd have to also add a new VET_COLOUR_RGBA which currently wouldn't be used by anything, which may puzzle some people :) We also couldn't really test it on anything.

If you want to submit a small patch to deal with this so that a Wii rendersystem is easier to write, that's fine and we'll accept it.
0 x

Crashy
Google Summer of Code Student
Google Summer of Code Student
Posts: 996
Joined: Wed Jan 08, 2003 9:15 pm
Location: Lyon, France
x 20
Contact:

Post by Crashy » Tue Dec 02, 2008 5:31 pm

Yup I'll make the patch. For the moment I made something ugly but I'll rewrite it and make it commit-able on Ogre.
0 x
Follow la Moustache on Twitter or on Facebook
Image

Post Reply