Zip file 'double close' problem

What it says on the tin: a place to discuss proposed new features.
Post Reply
User avatar
nikki
Old One
Posts: 2730
Joined: Sat Sep 17, 2005 10:08 am
Location: Princeton, New Jersey, USA
Contact:

Zip file 'double close' problem

Post by nikki » Sun Sep 27, 2009 11:59 pm

I've noticed a few people faced this problem before...

ZipDataStream calls 'close()' on itself in the destructor. If one calls 'close()' on it, when it goes out of scope it's called again, and this causes a segfault. I think it makes sense to check whether it's been closed previously, and only close it if not. Sure, you could say, "Don't call close(), just let it go out of scope", but then, what's the 'close()' function for? :P
0 x

User avatar
steven
Gnoll
Posts: 657
Joined: Mon Feb 28, 2005 1:53 pm
Location: Australia - Canberra (ex - Switzerland - Geneva)
Contact:

Re: Zip file 'double close' problem

Post by steven » Mon Sep 28, 2009 2:24 am

If you are referring to this it was fixed very recently. But in Shoggoth only ;)
0 x

CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
Contact:

Re: Zip file 'double close' problem

Post by CABAListic » Mon Sep 28, 2009 9:17 am

Shoggoth changes will get pushed to trunk eventually. Just give sinbad some time ;)
0 x

User avatar
nikki
Old One
Posts: 2730
Joined: Sat Sep 17, 2005 10:08 am
Location: Princeton, New Jersey, USA
Contact:

Re: Zip file 'double close' problem

Post by nikki » Mon Sep 28, 2009 11:06 am

CABAListic wrote:Shoggoth changes will get pushed to trunk eventually. Just give sinbad some time ;)
I see, I didn't know it was fixed. I'm on Cthugha. :)
0 x

Post Reply