Hi,
The fact that OGRE is modifying my GLSL after loading it is not intuitive. What is the motivation to do this anyway? I am voting for this feature to be removed. Please see this post. Thanks.
don't modify GLSL
-
cyrfer
- Orc
- Posts: 424
- Joined: Wed Aug 01, 2007 8:13 pm
- Location: Venice, CA, USA
- x 7
-
jacmoe
- OGRE Retired Moderator
- Posts: 20570
- Joined: Thu Jan 22, 2004 10:13 am
- Location: Denmark
- x 179
- Contact:
Re: don't modify GLSL
Why not continue the existing topic?
This is kind of fragmented..
This is kind of fragmented..
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.
-
cyrfer
- Orc
- Posts: 424
- Joined: Wed Aug 01, 2007 8:13 pm
- Location: Venice, CA, USA
- x 7
Re: don't modify GLSL
I don't think it makes sense to 'preprocess' the shader, and it is especially bad practice to modify the shader. That is the point of this feature request.
The other thread has identified that this may be happening due to some kind of bug in the OGRE preprocess-ing. Hopefully that can be resolved.
The other thread has identified that this may be happening due to some kind of bug in the OGRE preprocess-ing. Hopefully that can be resolved.
-
masterfalcon
- OGRE Team Member
- Posts: 4270
- Joined: Sun Feb 25, 2007 4:56 am
- Location: Bloomington, MN
- x 126
- Contact:
Re: don't modify GLSL
Yes, actually I think the problem is that you've been mistakenly thinking of what is possibly a bug as a feature. In fact, preprocessing is a good thing. It's necessary to let you to pass preprocessor defines in a material script.
Let's keep the conversation in the already established thread and let this one end here.
Let's keep the conversation in the already established thread and let this one end here.