Couple of missing billboard functions.

What it says on the tin: a place to discuss proposed new features.
Post Reply
User avatar
mkultra333
Gold Sponsor
Gold Sponsor
Posts: 1889
Joined: Sun Mar 08, 2009 5:25 am
x 36

Couple of missing billboard functions.

Post by mkultra333 » Tue Sep 14, 2010 12:53 pm

Two obvious functions I wanted from billboards that seem to be missing.

First up, there's no pBillboardset->SetMaterial(pMaterial) function. Minor issue, I used SetMaterialName instead, but SetMaterial would have been handier.

Secondly, there's pBillboard->setRotation(Radian) but no pBillboard->setFlip(U_andor_V). No way around this one that I can see, and from an art point of view flips are just as important as rotations. Lack of flips has halved the variation I can get from my animated explosion texture.

One other thing, currently rotation rotates UVs, so unless you're doing 90 degree rotations you have leave lots of headroom around your particles, virtually halving their resolution, or else the corners will rotate onto parts of the texture they shouldn't touch, causing visual glitches. I don't know if it's possible, but it'd be neat if there were a second rotation method that left the UVs intact and rotated the billboard vertices instead. I expect there'd be a speed penalty, but if it wasn't too high I'd be willing to pay it in some circumstances (such as with my explosion animation.)

I'll survive without these, but thought I'd mention them.
0 x
"In theory there is no difference between practice and theory. In practice, there is." - Psychology Textbook.

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: Couple of missing billboard functions.

Post by FlorianGeorge » Wed Oct 13, 2010 8:07 pm

yes, I just ran into the missing void BillBoardSet::setMaterial (const MaterialPtr &material) as well, would make sense to make it coherent with other similar objects, like SubEntities
0 x

User avatar
spookyboo
Silver Sponsor
Silver Sponsor
Posts: 1140
Joined: Tue Jul 06, 2004 5:57 am
x 15
Contact:

Re: Couple of missing billboard functions.

Post by spookyboo » Wed Oct 13, 2010 8:53 pm

Use setBillboardRotationType to either rotate uv or vertices.
0 x

User avatar
masterfalcon
OGRE Team Member
OGRE Team Member
Posts: 4270
Joined: Sun Feb 25, 2007 4:56 am
Location: Bloomington, MN
Contact:

Re: Couple of missing billboard functions.

Post by masterfalcon » Wed Oct 13, 2010 8:54 pm

Don't forget to enter bugs for feature requests too!
0 x

User avatar
ImpalerWrG
Gnoblar
Posts: 15
Joined: Sat Feb 27, 2010 7:42 am

Re: Couple of missing billboard functions.

Post by ImpalerWrG » Wed Nov 03, 2010 9:42 am

Bump on requesting SetMaterial(pMaterial), I'll see to getting it on your official feature request system. *Looks for feature request system* Come on already, this one is really quite obvious and I'm now going to have to create a whole system of name generating and string passing to do what I need as I'm using procedurally generated textures and materials. String arguments are for kiddie programs with 3 textures anyways, pointers are how real programs operate and should take precedent if only one is going to be available.
0 x
Companions the creator seeks, not corpses, not herds and believers. Fellow creators, the creator seeks - those who write new values on new tablets. Companions the creator seeks, and fellow harvesters; for everything about him is ripe for the harvest.

User avatar
Jabberwocky
OGRE Moderator
OGRE Moderator
Posts: 2819
Joined: Mon Mar 05, 2007 11:17 pm
Location: Canada
Contact:

Re: Couple of missing billboard functions.

Post by Jabberwocky » Sun Nov 07, 2010 1:54 am

Probably your best bet is to code the change yourself (ogre is open source), then submit a patch with your change to get it accepted into a future ogre release.
0 x
Image

User avatar
masterfalcon
OGRE Team Member
OGRE Team Member
Posts: 4270
Joined: Sun Feb 25, 2007 4:56 am
Location: Bloomington, MN
Contact:

Re: Couple of missing billboard functions.

Post by masterfalcon » Sun Nov 07, 2010 4:11 am

Yeah, you could either submit a patch or a bug. List the reproducibility as "Feature". http://www.ogre3d.org/mantis/
0 x

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: Couple of missing billboard functions.

Post by FlorianGeorge » Wed Dec 22, 2010 3:29 pm

Added it to Mantis: http://www.ogre3d.org/mantis/view.php?id=365

Category doesn't have a "Feature Request" option, so I selected "Core Library Bugs".
Reproducibility doesn't have the option "Feature", so I selected "always".
Feel free to add the missing options to the combo boxes and/or edit the entry as you see fit, was my first submission.
0 x

User avatar
betajaen
OGRE Moderator
OGRE Moderator
Posts: 3447
Joined: Mon Jul 18, 2005 4:15 pm
Location: Wales, UK
Contact:

Re: Couple of missing billboard functions.

Post by betajaen » Wed Dec 22, 2010 3:44 pm

If you put "[Papercut]" in there somewhere it is more likely to be noticed. ;)
0 x

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: Couple of missing billboard functions.

Post by FlorianGeorge » Thu Feb 10, 2011 9:17 pm

uploaded a patch (or two) a few weeks ago
0 x

Post Reply