[solved] Remove UTFString from OgreMain

Discussion area about developing or extending OGRE, adding plugins for it or building applications on it. No newbie questions please, use the Help forum for that.
Post Reply
User avatar
altren
Gnome
Posts: 317
Joined: Tue Oct 24, 2006 9:02 am
Location: Moscow, Russa
x 1
Contact:

[solved] Remove UTFString from OgreMain

Post by altren » Thu Jan 10, 2019 2:24 am

Since it is not used on OgreMain, have non-trivial code and also uses c++17 deprecated features (inheritance from std::iterator) I suggest to move it into OgreOverlay

There are only two places where it is used:
1. OgreDynLib.h

Code: Select all

#    define DYNLIB_LOAD( a ) LoadPackagedLibrary( UTFString(a).asWStr_c_str(), 0 )
2. OgreOverlayElement.h

Code: Select all

typedef UTFString DisplayString
OgreDynLib.h usage can be replaced with a single windows specific function
Last edited by altren on Sun Jan 13, 2019 9:13 pm, edited 1 time in total.
0 x
Image

paroj
OGRE Team Member
OGRE Team Member
Posts: 739
Joined: Sun Mar 30, 2014 2:51 pm
x 112
Contact:

Re: Remove UTFString from OgreMain

Post by paroj » Thu Jan 10, 2019 2:33 am

sounds good. can you create a pull-request for this?
0 x

User avatar
altren
Gnome
Posts: 317
Joined: Tue Oct 24, 2006 9:02 am
Location: Moscow, Russa
x 1
Contact:

Re: Remove UTFString from OgreMain

Post by altren » Thu Jan 10, 2019 3:19 am

Yes
0 x
Image

User avatar
altren
Gnome
Posts: 317
Joined: Tue Oct 24, 2006 9:02 am
Location: Moscow, Russa
x 1
Contact:

Re: Remove UTFString from OgreMain

Post by altren » Sat Jan 12, 2019 4:13 am

0 x
Image

Post Reply