BUG: changeset 10add4e8c978

Discussion area about developing or extending OGRE, adding plugins for it or building applications on it. No newbie questions please, use the Help forum for that.
Post Reply
Transporter
Minaton
Posts: 933
Joined: Mon Mar 05, 2012 11:37 am
Location: Germany
x 1

BUG: changeset 10add4e8c978

Post by Transporter » Thu Aug 16, 2012 10:03 am

https://bitbucket.org/sinbad/ogre/chang ... System.cpp

D3DPERF_BeginEvent, _EndEvent, etc. are part of the deprecated D3DX library from DX9!
2>C:\ogre\RenderSystems\Direct3D11\src\OgreD3D11RenderSystem.cpp(2932): error C3861: 'D3DPERF_BeginEvent': identifier not found
2>C:\ogre\RenderSystems\Direct3D11\src\OgreD3D11RenderSystem.cpp(2932): error C3861: 'D3DCOLOR_ARGB': identifier not found
2>C:\ogre\RenderSystems\Direct3D11\src\OgreD3D11RenderSystem.cpp(2938): error C3861: 'D3DPERF_EndEvent': identifier not found
2>C:\ogre\RenderSystems\Direct3D11\src\OgreD3D11RenderSystem.cpp(2949): error C3861: 'D3DPERF_SetMarker': identifier not found
2>C:\ogre\RenderSystems\Direct3D11\src\OgreD3D11RenderSystem.cpp(2949): error C3861: 'D3DCOLOR_ARGB': identifier not found
If you like to use this functions instead of the ID3DUserDefinedAnnotation interface (http://msdn.microsoft.com/en-us/library/hh446881.aspx) you have to add DX9 header and lib to the DX11 renderer:

Code: Select all

diff -r 27c064dada72 RenderSystems/Direct3D11/CMakeLists.txt
--- a/RenderSystems/Direct3D11/CMakeLists.txt	Wed Aug 15 02:24:37 2012 -0500
+++ b/RenderSystems/Direct3D11/CMakeLists.txt	Thu Aug 16 10:30:08 2012 +0200
@@ -75,6 +75,7 @@
 target_link_libraries(RenderSystem_Direct3D11
   OgreMain
   ${DirectX_D3D11_LIBRARIES}
+  ${DirectX_LIBRARY}
 )
 
 if (NOT OGRE_STATIC)
diff -r 27c064dada72 RenderSystems/Direct3D11/src/OgreD3D11RenderSystem.cpp
--- a/RenderSystems/Direct3D11/src/OgreD3D11RenderSystem.cpp	Wed Aug 15 02:24:37 2012 -0500
+++ b/RenderSystems/Direct3D11/src/OgreD3D11RenderSystem.cpp	Thu Aug 16 10:30:08 2012 +0200
@@ -53,6 +53,8 @@
 #include "OgreD3D11HardwarePixelBuffer.h"
 #include "OgreException.h"
 
+#include "d3d9.h"
+
 // DXGetErrorDescription
 #include "DXErr.h"
The patch has also been submitted to the bug tracker.
Attachments
dx11rendersystem.patch
Bugfix for changeset 10add4e8c978
(791 Bytes) Downloaded 85 times
0 x

User avatar
Eugene
OGRE Team Member
OGRE Team Member
Posts: 183
Joined: Mon Mar 24, 2008 4:54 pm
Location: Odessa, Ukraine

Re: BUG: changeset 10add4e8c978

Post by Eugene » Sat Aug 18, 2012 5:08 pm

Transporter wrote:If you like to use this functions instead of the ID3DUserDefinedAnnotation interface (http://msdn.microsoft.com/en-us/library/hh446881.aspx) you have to add DX9 header and lib to the DX11 renderer
Incompatible with WinRT!
0 x

User avatar
Wolfmanfx
OGRE Team Member
OGRE Team Member
Posts: 1525
Joined: Fri Feb 03, 2006 10:37 pm
Location: Austria - Leoben
x 1
Contact:

Re: BUG: changeset 10add4e8c978

Post by Wolfmanfx » Sat Aug 18, 2012 5:18 pm

Atm the moment i guarded them inside Ogre_profile for 1.8.1 so its optional but in the future we should use the dx11 specific functions which target win8 and above.
But i also do not know how much useable the dx11 rs in 1.8 is.
0 x

Transporter
Minaton
Posts: 933
Joined: Mon Mar 05, 2012 11:37 am
Location: Germany
x 1

Re: BUG: changeset 10add4e8c978

Post by Transporter » Sun Aug 19, 2012 5:06 pm

Wolfmanfx wrote:Atm the moment i guarded them inside Ogre_profile for 1.8.1 so its optional but in the future we should use the dx11 specific functions which target win8 and above.
But i also do not know how much useable the dx11 rs in 1.8 is.
The current DX11 code is instable. You should remove the whole profiling part from 1.8.0 and add it with the fix to 1.8.1. The new functions should be used after 1.8.1 release.
0 x

User avatar
Wolfmanfx
OGRE Team Member
OGRE Team Member
Posts: 1525
Joined: Fri Feb 03, 2006 10:37 pm
Location: Austria - Leoben
x 1
Contact:

Re: BUG: changeset 10add4e8c978

Post by Wolfmanfx » Sun Aug 19, 2012 5:11 pm

There is no 1.8.1 tag so we push fixes into the 1.8 branch and make a tag when we release it.
0 x

Post Reply