Page 1 of 1

i think there is a bug in OgreFileSystem.cpp with v1.8.1

Posted: Fri Oct 26, 2012 9:55 am
by zhendong
in this file, the function FileSystemArchive::open, at the line 229, it write: "if (!readOnly && isReadOnly()) {...", i think it's incorrect, it may be like this: "if (!readOnly && !isReadOnly) {...

Re: i think there is a bug in OgreFileSystem.cpp with v1.8.1

Posted: Fri Oct 26, 2012 10:14 am
by Eugene
zhendong wrote:in this file, the function FileSystemArchive::open, at the line 229, it write: "if (!readOnly && isReadOnly()) {...", i think it's incorrect, it may be like this: "if (!readOnly && !isReadOnly) {...
Look at http://www.ogre3d.org/forums/viewtopic.php?f=4&t=72885 - this bug is already fixed by changeset

Code: Select all

Changeset:3902 (accc2be2d8e4) Fix a bug in the filesystem when a read-write file was being opened in read-only
Branch: v1-8 
User:David Rogers <masterfalcon@ogre3d.org>
Date:2012-10-01 13:32:02 -0500 (3 weeks)
and would be released as part of v1.8.2

Re: i think there is a bug in OgreFileSystem.cpp with v1.8.1

Posted: Sat Oct 27, 2012 4:45 am
by zhendong
Eugene wrote:
zhendong wrote:in this file, the function FileSystemArchive::open, at the line 229, it write: "if (!readOnly && isReadOnly()) {...", i think it's incorrect, it may be like this: "if (!readOnly && !isReadOnly) {...
Look at http://www.ogre3d.org/forums/viewtopic.php?f=4&t=72885 - this bug is already fixed by changeset

Code: Select all

Changeset:3902 (accc2be2d8e4) Fix a bug in the filesystem when a read-write file was being opened in read-only
Branch: v1-8 
User:David Rogers <masterfalcon@ogre3d.org>
Date:2012-10-01 13:32:02 -0500 (3 weeks)
and would be released as part of v1.8.2
Oh I know that ,thank you