delete compositor logic - patch ?

A place for users of OGRE to discuss ideas and experiences of utilitising OGRE in their games / demos / applications.
Post Reply
moagames
Halfling
Posts: 70
Joined: Thu Apr 10, 2008 8:10 pm

delete compositor logic - patch ?

Post by moagames » Thu Apr 01, 2010 9:08 am

Hi,

looking into the ogre source and the compositor demo, i just couldn't see, where the registered compositor logics are deleted.
In the demo the compositor logic is registered through

Code: Select all

compMgr.registerCompositorLogic("HDR", new HDRLogic);
so there is no pointer to this logic saved to delete upon shutdown. Also in the ogre source i couldn't find any code that deletes all registered compositor logics upon shutdown (what i would prefer). I couldn't even find a way to unregister the compositor logic manually once it isn't needed anymore.
Is this really a memory leak in ogre/compositor demo and a missing feature, or am i just missing something ?


Thanks.
Last edited by moagames on Tue Apr 06, 2010 9:07 am, edited 1 time in total.
0 x

moagames
Halfling
Posts: 70
Joined: Thu Apr 10, 2008 8:10 pm

Re: delete compositor logic

Post by moagames » Tue Apr 06, 2010 9:06 am

I looked a bit deeper in the Ogre code and still couldn't find any call to delete the registered Compositor logics.
Furthermore I saw, that the same issue also exists with "registerCustomCompositionPass.

So I now changed Ogre a bit and added the possibility to delete registered compositor logics and custom composition passes (single ones or all registered at once).
Also an auto delete at shutdown is added.

If needed, I can submit a patch for this change.
0 x

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: delete compositor logic - patch ?

Post by FlorianGeorge » Sat Sep 18, 2010 6:52 pm

I ran into the same issue playing with the Gaussian Blur compositor from the same demo. Visual Leak Detector doesn't like this one bit.

I am very interested in your unregisterCompositorLogic code and would like to see your patches being added to the official ogre source.
0 x

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: delete compositor logic - patch ?

Post by FlorianGeorge » Wed Dec 22, 2010 3:46 pm

0 x

moagames
Halfling
Posts: 70
Joined: Thu Apr 10, 2008 8:10 pm

Re: delete compositor logic - patch ?

Post by moagames » Mon Jan 03, 2011 2:54 pm

I submitted the patch to the mantis ticket.

BR
0 x

FlorianGeorge
Halfling
Posts: 86
Joined: Tue Sep 01, 2009 7:15 pm
Location: Cologne, Germany

Re: delete compositor logic - patch ?

Post by FlorianGeorge » Mon Feb 14, 2011 6:34 pm

Tested the changes dark_sylinc committed to the 1.8 unstable mercurial.

For both the Compositor Sample and the Deferred Shading Sample, Visual Leak Detector 2.0b doesn't detect any leaks anymore.

Guess you can close this as fixed now.
0 x

arkeon
Goblin
Posts: 271
Joined: Fri Dec 04, 2009 6:02 pm
x 4

Re: delete compositor logic - patch ?

Post by arkeon » Tue Sep 10, 2013 3:49 pm

In Ogre 1.8 unregisterAllCustomCompositionPasses and unregisterCustomCompositionPasse are gone ?!
0 x
OpenSpace 3D Project manager
http://www.openspace3d.com

cyrfer
Orc
Posts: 424
Joined: Wed Aug 01, 2007 8:13 pm
Location: Venice, CA, USA
x 2

Re: delete compositor logic - patch ?

Post by cyrfer » Wed Feb 18, 2015 9:33 pm

I've come across this several times. I wonder what ever came of it.
0 x

Post Reply