[2.1+] Planar Reflection doesn't work (with fix) Topic is solved

[rujialiu]

Hi!

In the latest commit, planar reflection doesn't work anymore. The code in question:

Code: Select all

struct PS_INPUT
{
@insertpiece( VStoPS_block )
    float4 gl_Position: SV_Position;
    @foreach( n, hlms_pso_clip_distances )
        float gl_ClipDistance@n : SV_ClipDistance@n;
    @end
};

For some reason, foreach doesn't work as expected so gl_ClipDistance0 is not defined. It can be fixed by reverting foreach to property:

Code: Select all

struct PS_INPUT
{
@insertpiece( VStoPS_block )
    float4 gl_Position: SV_Position;
    @property( hlms_pso_clip_distances )
        float gl_ClipDistance0 : SV_ClipDistance0;
    @end
};

I've tested both D3D11 and Metal and they both work after the fix.

[dark_sylinc]

Are you sure you're on latest?

That bug was fixed a few months ago. The problem was that:

Code: Select all

@foreach( n, hlms_pso_clip_distances )

Should've been:

Code: Select all

@foreach( hlms_pso_clip_distances, n )

The latest version has the correct one. What commit hash are you working on?

Cheers

[rujialiu]

Are you sure you're on latest?

That bug was fixed a few months ago. The problem was that:

Code: Select all

@foreach( n, hlms_pso_clip_distances )

Should've been:

Code: Select all

@foreach( hlms_pso_clip_distances, n )

The latest version has the correct one. What commit hash are you working on?

Cheers

Oops, I didn't update Ogre 2.1 for exactly one month (though I updated Ogre 2.2 yesterday)
I'll update immediately.