[2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material Topic is solved

Discussion area about developing with Ogre2 branches (2.1, 2.2 and beyond)
Post Reply
rujialiu
Goblin
Posts: 276
Joined: Mon May 09, 2016 8:21 am
x 33

[2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Post by rujialiu »

Hi!

With a material with FLAG_SPERATE_DIFFUSE_FRESNEL, if hlms piece BRDF_EnvMap is used, shader will fail to compile because piece getDiffuseFresnelWithRoughness used NdotL, but the definition of NdotL is commented at the beginning of @piece BRDF_EnvMap. It looks like uncommenting that line will not cause other problems?

Thanks!

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 4266
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 835
Contact:

Re: [2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Post by dark_sylinc »

Hi!

I remember I commented it because I saw NdotL was not being used. Obviously, I saw wrong.

Thanks for the report!

rujialiu
Goblin
Posts: 276
Joined: Mon May 09, 2016 8:21 am
x 33

Re: [2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Post by rujialiu »

dark_sylinc wrote:
Fri Feb 22, 2019 5:00 pm
Thanks for the report!
Thanks for the fix!

Post Reply