[3.0] MyGUI build working for Ogre-Next 3.0

Discussion area about developing with Ogre-Next (2.1, 2.2 and beyond)


Lax
Hobgoblin
Posts: 583
Joined: Mon Aug 06, 2007 12:53 pm
Location: Saarland, Germany
x 50

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Lax »

Hi,

thanks for the guide.
I will take a look shortly.

Best Regards
Lax

http://www.lukas-kalinowski.com/Homepage/?page_id=1631
Please support Second Earth Technic Base built of Lego bricks for Lego ideas: https://ideas.lego.com/projects/81b9bd1 ... b97b79be62

Lax
Hobgoblin
Posts: 583
Joined: Mon Aug 06, 2007 12:53 pm
Location: Saarland, Germany
x 50

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Lax »

Hi,

I'm trying to set the upstream for my branch, but always get the error:

I sign in via code and everything does work. But after that I get:

Code: Select all

$ git push -u origin mygui_custom_extensions_laxx18
remote: Permission to sercero/mygui.git denied to Laxx18.
fatal: unable to access 'https://github.com/sercero/mygui.git/': The requested URL returned error: 403

The strange thing is, each time, I try to set the upstream, I have to sign in, even I'm signed in^^. I also have my own github account for Laxx18.
What can that be?

Best Regards
Lax

http://www.lukas-kalinowski.com/Homepage/?page_id=1631
Please support Second Earth Technic Base built of Lego bricks for Lego ideas: https://ideas.lego.com/projects/81b9bd1 ... b97b79be62

User avatar
sercero
Bronze Sponsor
Bronze Sponsor
Posts: 449
Joined: Sun Jan 18, 2015 4:20 pm
Location: Buenos Aires, Argentina
x 156

Re: [3.0] MyGUI build working for Ogre 3.0

Post by sercero »

Lax wrote: Sun Mar 12, 2023 9:57 pm

Hi,

I'm trying to set the upstream for my branch, but always get the error:

I sign in via code and everything does work. But after that I get:

Code: Select all

$ git push -u origin mygui_custom_extensions_laxx18
remote: Permission to sercero/mygui.git denied to Laxx18.
fatal: unable to access 'https://github.com/sercero/mygui.git/': The requested URL returned error: 403

The strange thing is, each time, I try to set the upstream, I have to sign in, even I'm signed in^^. I also have my own github account for Laxx18.
What can that be?

Best Regards
Lax

No, that repo should be yours.

You don't have permission because you are trying to push into my repo.

And also the upstream would NOT be my repo, but this one: https://github.com/MyGUI/mygui

If you have more questions perhaps it would be better to continue by PM to avoid annoying the people in the forums.
:wink:

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 5296
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 1278
Contact:

Re: [3.0] MyGUI build working for Ogre 3.0

Post by dark_sylinc »

@Lax: A layman explanation of Pull Requests is the following:

  1. You want to contribute to upstream, i.e. https://github.com/MyGUI/mygui

  2. You go to https://github.com/MyGUI/mygui and click Fork. This will create a full copy of the entire repo just for you. Let's say your repo is now github.com/Lax/mygui

  3. You push your changes to github.com/Lax/mygui

  4. You go to github.com/MyGUI/mygui -> Pull Requests -> Create / New -> and select your fork and the branch you want to request for merge

  5. The managers of https://github.com/MyGUI/mygui will evaluate it and either merge it, reject it (or leave it there if they forget or don't have time)

Cheers

Lax
Hobgoblin
Posts: 583
Joined: Mon Aug 06, 2007 12:53 pm
Location: Saarland, Germany
x 50

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Lax »

Hi,

now I understand.
I will go dark_sylinc's way.

Thanks.

Best Regards
Lax

http://www.lukas-kalinowski.com/Homepage/?page_id=1631
Please support Second Earth Technic Base built of Lego bricks for Lego ideas: https://ideas.lego.com/projects/81b9bd1 ... b97b79be62

Lax
Hobgoblin
Posts: 583
Joined: Mon Aug 06, 2007 12:53 pm
Location: Saarland, Germany
x 50

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Lax »

Oh boy,

this is harder as I thought.
I'm struggle with cmake now:

Code: Select all

Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.19045.
Configuring MYGUI 3.4.2
ERROR    compiled OGRE DLL's wasn't found
Could NOT find Freetype (missing: FREETYPE_LIBRARY FREETYPE_INCLUDE_DIRS) 
Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR) 
Could NOT find SDL2 (missing: SDL2_INCLUDE_DIR SDL2_LIBRARY) 
Original FindOGRE.cmake found in OGRE_SOURCE_DIR, trying to use it
Looking for OGRE...
CMake Error at E:/Ogre2.2SDK/CMake/Packages/FindOGRE.cmake:76 (get_debug_names):
  Unknown CMake command "get_debug_names".
Call Stack (most recent call first):
  CMake/Packages/FindOGRE_Old.cmake:42 (FIND_PACKAGE)
  CMake/Dependencies.cmake:51 (find_package)
  CMakeLists.txt:189 (include)


Configuring incomplete, errors occurred!
See also "E:/mygui/VCBuild/CMakeFiles/CMakeOutput.log".

I set in the cmake config:

OGRE_BUILD to E:/Ogre2.2SDK/VCBuild/bin
OGRE_DIR to E:/Ogre2.2SDK/CMake
Ogre_SOURCE: to E:/Ogre2.2SDK

Whats also really strange. I have no Idea, where you have the OgrePlatform for mygui from?
Because the version I have, all files do look like this one:

MyGUI_Ogre2DataManager.h
-> Ogre2...

I also made a winmerge between your files and my files and its a whole different approach.

I don't think, this can be merged...

See attached picture, for just one file:
https://lukas-kalinowski.com/Homepage/w ... uidiff.png

I have no idea what todo, I'm sorry.

Best Regards
Lax

http://www.lukas-kalinowski.com/Homepage/?page_id=1631
Please support Second Earth Technic Base built of Lego bricks for Lego ideas: https://ideas.lego.com/projects/81b9bd1 ... b97b79be62

User avatar
sercero
Bronze Sponsor
Bronze Sponsor
Posts: 449
Joined: Sun Jan 18, 2015 4:20 pm
Location: Buenos Aires, Argentina
x 156

Re: [3.0] MyGUI build working for Ogre 3.0

Post by sercero »

Lax wrote: Mon Mar 13, 2023 7:52 pm

Oh boy,

this is harder as I thought.
I'm struggle with cmake now:

Code: Select all

Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.19045.
Configuring MYGUI 3.4.2
ERROR    compiled OGRE DLL's wasn't found
Could NOT find Freetype (missing: FREETYPE_LIBRARY FREETYPE_INCLUDE_DIRS) 
Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR) 
Could NOT find SDL2 (missing: SDL2_INCLUDE_DIR SDL2_LIBRARY) 
Original FindOGRE.cmake found in OGRE_SOURCE_DIR, trying to use it
Looking for OGRE...
CMake Error at E:/Ogre2.2SDK/CMake/Packages/FindOGRE.cmake:76 (get_debug_names):
  Unknown CMake command "get_debug_names".
Call Stack (most recent call first):
  CMake/Packages/FindOGRE_Old.cmake:42 (FIND_PACKAGE)
  CMake/Dependencies.cmake:51 (find_package)
  CMakeLists.txt:189 (include)


Configuring incomplete, errors occurred!
See also "E:/mygui/VCBuild/CMakeFiles/CMakeOutput.log".

I set in the cmake config:

OGRE_BUILD to E:/Ogre2.2SDK/VCBuild/bin
OGRE_DIR to E:/Ogre2.2SDK/CMake
Ogre_SOURCE: to E:/Ogre2.2SDK

Whats also really strange. I have no Idea, where you have the OgrePlatform for mygui from?
Because the version I have, all files do look like this one:

MyGUI_Ogre2DataManager.h
-> Ogre2...

I also made a winmerge between your files and my files and its a whole different approach.

I don't think, this can be merged...

See attached picture, for just one file:
https://lukas-kalinowski.com/Homepage/w ... uidiff.png

I have no idea what todo, I'm sorry.

Best Regards
Lax

Hey Lax, I saw the screenshot.

You are comparing OgreRenderManager and Ogre2RenderManager.

Of course they are going to be very different and thats how that should be.

I though that you were going to contribute your changes:

I made some small changes over years here and there in the sources.

You should concentrate on the small changes you made to MyGUI.

If your changes were in Ogre2RenderManager, then perhaps you should contribute to one of the forks of MyGUI that deals with Ogre 2.x.

I'm sorry that I got you into this mess, I though it would be easier.

Lax
Hobgoblin
Posts: 583
Joined: Mon Aug 06, 2007 12:53 pm
Location: Saarland, Germany
x 50

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Lax »

Hi sercero,

Ok, I compare just MyGUI and make some commits bit by bit to see, what I have changed and contribute that.

Best Regards
Lax

http://www.lukas-kalinowski.com/Homepage/?page_id=1631
Please support Second Earth Technic Base built of Lego bricks for Lego ideas: https://ideas.lego.com/projects/81b9bd1 ... b97b79be62

User avatar
sercero
Bronze Sponsor
Bronze Sponsor
Posts: 449
Joined: Sun Jan 18, 2015 4:20 pm
Location: Buenos Aires, Argentina
x 156

Re: [3.0] MyGUI build working for Ogre 3.0

Post by sercero »

@Lax,

I think that now I understand what is your problem.

On one hand you have a fork of MyGUI: https://github.com/Laxx18/mygui

But that fork is in sync with MyGUI master and you are not working with that repo.

Your changes are here: https://github.com/Laxx18/NOWA-Engine/t ... yGUIEngine

You need to compare only the directory: MyGUIEngine and ignore the "Tools" and "Ogre2Platform" directories.

I have made the comparison and saw that in general you are behind the latest changes in MyGUI master so you need to incoroporate those changes and then create a diff with the things you changed in your engine (NOWA).

Lax
Hobgoblin
Posts: 583
Joined: Mon Aug 06, 2007 12:53 pm
Location: Saarland, Germany
x 50

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Lax »

Hi,

I made a pull request:

https://github.com/MyGUI/mygui/pull/247

Best Regards
Lax

http://www.lukas-kalinowski.com/Homepage/?page_id=1631
Please support Second Earth Technic Base built of Lego bricks for Lego ideas: https://ideas.lego.com/projects/81b9bd1 ... b97b79be62

User avatar
Crystal Hammer
Gnome
Posts: 317
Joined: Sat Jun 23, 2007 5:16 pm
x 77
Contact:

Re: [3.0] MyGUI build working for Ogre 3.0

Post by Crystal Hammer »

I added separate CMake files for Windows build. (If you know a better way, PRs are welcome).
Also updated readme for Windows builds.
It is working fine in Stunt Rally 3.0 beta (how to get its RC2 here for Windows).

Post Reply