Missing output of shader source in Hlms::_compileShaderFromPreprocessedSource

Discussion area about developing with Ogre-Next (2.1, 2.2 and beyond)


User avatar
bishopnator
Goblin
Posts: 299
Joined: Thu Apr 26, 2007 11:43 am
Location: Slovakia / Switzerland
x 11

Missing output of shader source in Hlms::_compileShaderFromPreprocessedSource

Post by bishopnator »

Ogre version 2.3.4 (Daedalus)

If Ogre::Hlms::mDebugOutput is set to true (through Hlms::setDebugOutputPath), the shader code is node written to the output file in Hlms::_compileShaderFromPreprocessedSource. Writing of source[ i ] is missing there which led to empty files (or only the properties/pieces are written).

Code: Select all

debugDumpFile.write(source[i].c_str(), source[i].size());

Image

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 5433
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 1341

Re: Missing output of shader source in Hlms::_compileShaderFromPreprocessedSource

Post by dark_sylinc »

That bug has been bothering me for years but I never took the time to look into it.

Thanks!

Pushed your fix.