We're trying this plugin and it's awesome. Has a couple mem. leaks on exit, but nothing serious.
First, it's worth noting that
if two files have the exact same name in two different folders (i.e. "Path1/MyMaterial.material" & "Path2/MyMaterial.material") the first parsed script will overwrite whatever content is in the parsed files to follow; causing a few bugs if you don't catch them.
Normally the plug-in would read the timestamps and identify them as different, but in some cases (as it happens with installed applications, or with files maintained through subversion) the timestamps will match, and the bug arise
Second, in file ScriptSerializerPlugin.cpp, line 30:
Code: Select all
void ScriptSerializerPlugin::shutdown() {
OGRE_DELETE mSerializeManager;
}
Should be:
Code: Select all
void ScriptSerializerPlugin::shutdown() {
OGRE_DELETE mSerializeManager;
mSerializeManager = 0;
}
Because it's never set to 0, it may crash if the application calls Root::shutdown() twice (which usually happens if shutdown() is called, and later delete mRoot happens)
Thanks again for this wonderful plugin!
Cheers