Bug in OgreTerrain?

[grubi]

Hello,

I'm currently studying the terrain component a bit and stumbled over a line I think it contains a bug.

Code: Select all

void Terrain::_setLightMapRequired(bool lightMap, bool shadowsOnly)
	{
		if (lightMap != mLightMapRequired || shadowsOnly != mLightMapShadowsOnly)
		{
			mLightMapRequired = lightMap;
			mLightMapShadowsOnly = mLightMapShadowsOnly;

Shouldn't it look more like this?

Code: Select all

mLightMapShadowsOnly = shadowsOnly;

Greets grubi

[jacmoe]

Does look like a bug.

/* moved to papercuts */

[Alquerian]

Shouldn't it look more like this?

Code: Select all

mLightMapShadowsOnly = shadowsOnly;

Agreed, that appears to be a logic error.