ShaderSystem sample requires CG on OSX

Minor issues with the Ogre API that can be trivial to fix
User avatar
Wolfmanfx
OGRE Team Member
OGRE Team Member
Posts: 1525
Joined: Fri Feb 03, 2006 10:37 pm
Location: Austria - Leoben
x 99

ShaderSystem sample requires CG on OSX

Post by Wolfmanfx »

Hi,

Code: Select all

Ogre::StringVector Sample_ShaderSystem::getRequiredPlugins()
{
	StringVector names;
    if (!GpuProgramManager::getSingleton().isSyntaxSupported("glsles"))
        names.push_back("Cg Program Manager");
	return names;
}
As you can see the ShaderSystem sample always require the CG plugin, except on ios build with glsles support, but i do not build the CG plugin at all on OSX. So maybe a cMake var is needed (when its not already there) which tells us if the CG program manager is builded at all. So that we guard this thing we remove the dep.
CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
x 58

Re: ShaderSystem sample requires CG on OSX

Post by CABAListic »

Does the ShaderSystem generator even support non-Cg profiles (apart from glsles)? Because if it doesn't, then that dependency is correct.
User avatar
Wolfmanfx
OGRE Team Member
OGRE Team Member
Posts: 1525
Joined: Fri Feb 03, 2006 10:37 pm
Location: Austria - Leoben
x 99

Re: ShaderSystem sample requires CG on OSX

Post by Wolfmanfx »

No there are native writers available => GLSL, HLSL, GLSLES and CG
so CG is optional