required CMake version

Minor issues with the Ogre API that can be trivial to fix
User avatar
tdev
Silver Sponsor
Silver Sponsor
Posts: 244
Joined: Thu Apr 12, 2007 9:21 pm
Location: Germany
x 14

required CMake version

Post by tdev »

it seems that the cmake version requirement should be increased.

tested to compile with (default debian lenny cmake)

Code: Select all

# cmake -version
cmake version 2.6-patch 0
which throws the following error:

Code: Select all

/var/lib/hudson/jobs/Ogre3d/workspace/CMakeLists.txt:23:
Parse error.  Function missing ending ")".  Instead found left paren with text "(".
-- Configuring done
after installing cmake-2.8 the error went away. So i propose to increase

Code: Select all

cmake_minimum_required(VERSION 2.6.2)
User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
x 179

Re: required CMake version

Post by jacmoe »

I think we could up it even more, although we might upset some Debian stable user.. Not sure.
Why not at least 2.8 ?
CABAListic knows for sure. :wink:
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.
CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
x 58

Re: required CMake version

Post by CABAListic »

I'd rather underestimate the required version than overestimate it, so as not to accidentally exclude any version that would actually work fine. But given that 2.6.0 does not work, an increase to 2.6.2 would probably be fine. If anyone is willing to find the exact minimum required version, I'd appreciate it.