Missing Billboard::get/setDirection?

Minor issues with the Ogre API that can be trivial to fix
User avatar
Xavyiy
OGRE Expert User
OGRE Expert User
Posts: 847
Joined: Tue Apr 12, 2005 2:35 pm
Location: Albacete - Spain
x 87

Missing Billboard::get/setDirection?

Post by Xavyiy »

Hi all!
While looking into how rendering efficient thunderstorm lighting effects in SkyX, I obviously came across the Billboard and BillboardChain classes :)

The fact is that I've in mind two different geometry approaches, one of them involves the BillboardChain class and the other one self oriented billboards, so for the second one accessing to Billboard::mDirection is needed. (Yes, I think finally I'll implement both methods... I really need to see how them looks! and if finally both approaches gives cool results, I'll leave to the end user the choice!)

Billboard::mDirection is public, so accessing to it it's not a problem, but since all other attributes(position, dimensions, colour...) have their own get/set functions I think it's a good idea to add get/set functions for the direction attribute.

P.D.: Hope not to bore you with my stories:)!

Edit: While looking to sources, I find that:

Code: Select all

// Note the intentional public access to main internal variables used at runtime
// Forcing access via get/set would be too costly for 000's of billboards
Anyway I think get/set methods must been provided as them are provided for the other attributes!