Bug in Ogre 1.8 With ContentScalingFactor

[anlumo]

Hi,

I think I've found a bug in the new GLES2 implementation in Ogre 1.8.

In EAGL2Window::create at the bottom there is the following line:

Code: Select all

// Resize, taking content scaling factor into account
resize(mWidth, mHeight);

However, in EAGL2Window::resize, the second check is:

Code: Select all

if(mWidth == width && mHeight == height)
            return;

Since the method is called with mWidth and mHeight as parameters, this condition always evaluates to true, and thus the resize call does nothing. This causes the content scaling factor to not be set properly on the view, and so the framebuffer is not scaled.

Should I file a bug about this?

[masterfalcon]

Yes, please. Additionally, are you calling resize directly? What is the usage situation?

[anlumo]

Additionally, are you calling resize directly? What is the usage situation?

No, I'm not calling it directly.

[anlumo]

http://www.ogre3d.org/mantis/view.php?id=464

[masterfalcon]

Thanks for filing the bug. If you're not calling it directly then how is it being called?

[anlumo]

Thanks for filing the bug. If you're not calling it directly then how is it being called?

As I said in the initial post, EAGL2Window::create calls it.