[solved] documentation for compositor passes

Minor issues with the Ogre API that can be trivial to fix
cyrfer
Orc
Posts: 424
Joined: Wed Aug 01, 2007 8:13 pm
Location: Venice, CA, USA
x 7

[solved] documentation for compositor passes

Post by cyrfer »

After reading and trying to use the documentation for the clear and stencil passes, I think it is not correct.

I have this inside my compositor's target operation:

Code: Select all

			pass clear
			{
				// THESE DO NOT SEEM TO HAVE AN EFFECT
				buffers colour depth stencil
				colour_value 1 1 1 1
				depth_value 1.0
				stencil_value 0.0
			}

			pass stencil
			{
				check off
				comp_func always_pass
				ref_value 1
				pass_op replace
				//mask 4294967295
				fail_op keep
				depth_fail_op keep
				two_sided off
			}
But my log file says this:
14:24:28: Compiler error: unknown error in deferred.compositor(168): token "buffers" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(169): token "colour_value" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(170): token "depth_value" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(171): token "stencil_value" is not recognized

14:24:28: Compiler error: unknown error in deferred.compositor(204): token "check" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(205): token "comp_func" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(206): token "ref_value" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(207): token "pass_op" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(209): token "fail_op" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(210): token "depth_fail_op" is not recognized
14:24:28: Compiler error: unknown error in deferred.compositor(211): token "two_sided" is not recognized
Is the documentation wrong or am I just not able to understand it?

I am using the Hg source code for 1.8.0 (before the 1.8 branch was created). Thanks for any help.
[edit] Here is the Mantis issue[/edit]
Last edited by cyrfer on Wed Dec 07, 2011 9:51 pm, edited 1 time in total.
User avatar
Noman
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 714
Joined: Mon Jan 31, 2005 7:21 pm
Location: Israel
x 2

Re: documentation for compositor passes

Post by Noman »

Here is a thread with a similar issue and an answer. It is for the clear pass, but I'm guessing the stencil pass is the same.
cyrfer
Orc
Posts: 424
Joined: Wed Aug 01, 2007 8:13 pm
Location: Venice, CA, USA
x 7

Re: [solved] documentation for compositor passes

Post by cyrfer »

Does this recent commit imply a grammar change? It was kinda redundant before - thanks for the improvement!
User avatar
masterfalcon
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 4270
Joined: Sun Feb 25, 2007 4:56 am
Location: Bloomington, MN
x 126

Re: [solved] documentation for compositor passes

Post by masterfalcon »

Nah, I reverted the commit because it was breaking a bunch of the samples. I'll review it soon and see if it's ok again.

[Edit] Ok, I have no idea what I was seeing before but the samples work fine with the patch applied.