Unused parameter in SceneManager::_renderScene

Nodrev · Post by **Nodrev** » Tue Mar 13, 2012 5:27 pm

The function signature use a boolean "includeOverlays" that is never used.

void SceneManager::_renderScene(Camera* camera, Viewport* vp, bool includeOverlays)

Instead, overlays rendering are tested with the current viewport that is being rendered:

Code: Select all

// Add overlays, if viewport deems it
if (vp->getOverlaysEnabled() && mIlluminationStage != IRS_RENDER_TO_TEXTURE)
{
	OverlayManager::getSingleton()._queueOverlaysForRendering(camera, getRenderQueue(), vp);
}

So, it seem that it's usefulness to keep this parameter there (and in calling function like Camera::renderScene, etc...), or maybe it was kept just for retro-compatibility?