Compositor visibility masks

[Fedyakin]

I believe there is a bug in the way compositors handle visibility flags. When a compositor script doesn't explicitly set a visibility mask, it uses the mask from the previous operation. This chains back to the automatically created original scene compositor. CompositorChain::preViewportUpdate sets that compositors mask to the current viewport's mask. However, in CompositorChain::preTargetOperation() it applies the operation's mask to the scene manager. This means that when compositors are being used, any use of the scene manager visibility flags by client code is silently ignored.

I propose that compositors should never modify SceneManager visibility flags, only the Viewport visibility flags. The visibility tests already use the combined viewport and scene manager visibility flags. This change allows the scene manager flags to function when compositors are present, and not lose any existing compositor functionality.

I have a patch that implements this (and updates the compositor script documentation). Is this change acceptable, or is there a better way to fix the problem?

[razi]

So I see this patch was ignored. I think this bug should be fixed, its basically just commenting out one line.

[masterfalcon]

Was the patch ever submitted to the patch tracker?

[Fedyakin]

I didn't submit a patch to the patch tracking system. The proposal slightly changes the behavior of compositors and I wasn't sure if that was acceptable. However, I created a ticket in mantis http://www.ogre3d.org/mantis/view.php?id=513. The ticket includes a patch implementing the proposed change.

[masterfalcon]

Ok, that's good. I'm sure it'll get checked out at some point. Don't worry.

[Transporter]

Don't worry, I've waited about a month until my patches have been accepted.

At this point I have to say that the ogre team did a great job over the last weeks. There have been so many changes (look at changelog). Ogre seems to be a living project.

[FlorianGeorge]

As you are already digging into Compositors, could you maybe check whether this bug is fixable: http://www.ogre3d.org/forums/viewtopic.php?f=2&t=62811