The hgext.win32text extension

Discussion area about developing or extending OGRE, adding plugins for it or building applications on it. No newbie questions please, use the Help forum for that.
PhilipLB
Google Summer of Code Student
Google Summer of Code Student
Posts: 550
Joined: Thu Jun 04, 2009 5:07 pm
Location: Berlin
x 108

The hgext.win32text extension

Post by PhilipLB »

Hi,

the wiki recommends to switch on this extension here: http://www.ogre3d.org/tikiwiki/tiki-ind ... ortoise_hg
But it's deprecated by now and might be removed in future HG versions, see http://mercurial.selenic.com/wiki/Win32TextExtension .
They recommend to use the EolExtension: http://mercurial.selenic.com/wiki/EolExtension
Maybe Ogre should use it, too?
Google Summer of Code 2012 Student
Topic: "Volume Rendering with LOD aimed at terrain"
Project links: Project thread, WIKI page, Code fork for the project
Mentor: Mattan Furst


Volume GFX, accepting donations.
User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
x 179

Re: The hgext.win32text extension

Post by jacmoe »

I don't think Ogre uses any code or files which requires either extension.
It works great for Ogitor, so I can't see why it shouldn't work for Ogre as well: no extensions.

The recommendation is to not use either extension. ;)

The only place where I found a need for the eol extension is the OgreAppwizard project since a few of the Visual Studio wizard files needs to be stored in Windows native format.

And, yes: Ogitor also makes use of .user project setting files for setting up debugging options for VS. And those doesn't need to be stored native.
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.
CABAListic
OGRE Retired Team Member
OGRE Retired Team Member
Posts: 2903
Joined: Thu Jan 18, 2007 2:48 pm
x 58

Re: The hgext.win32text extension

Post by CABAListic »

The relevant point is that any commit to the repository uses consistent line endings (in our case LF, i.e. Unix). How you achieve that is irrelevant - either configure your editor appropriately, or use the extension to convert for you. Given that most Windows editors (including Visual Studio) default to CR LF, care needs to be taken on Windows either way.
User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
x 179

Re: The hgext.win32text extension

Post by jacmoe »

In my experience, zero attention is required.

When checking out from a repository, all files will be checked out in Unix native format.
VS respects that format.
Notepad++ too.

I can't really think of any situation where it matters...

Except for a couple of files used by Visual Studio appwizard engine - but that is one particular situation which doesn't occur unless you happen to target that engine specifically.
It bit me in the rear when cloning a fresh copy onto my Windows box as all files now were Unix native.
So I made this .hgeol:

Code: Select all

[patterns]
**.props = CRLF
**.vcxproj = CRLF
**.vcproj = CRLF
**.vsdir = CRLF
**.vsz = CRLF
As you can see, Ogre doesn't store any of those, so it doesn't matter. :)
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.
User avatar
jacmoe
OGRE Retired Moderator
OGRE Retired Moderator
Posts: 20570
Joined: Thu Jan 22, 2004 10:13 am
Location: Denmark
x 179

Re: The hgext.win32text extension

Post by jacmoe »

It is labeled as a feature of last resort by the Mercurial team.

And since all decent editors (including Visual Studio) do not change the line endings of files, it is not a problem in practice.

So it should be left out of the doc on Mercurial dev practices for Ogre IMO.
/* Less noise. More signal. */
Ogitor Scenebuilder - powered by Ogre, presented by Qt, fueled by Passion.
OgreAddons - the Ogre code suppository.