OgreSharedPtr implicit conversion to bool

[longer]

use dummy member function can do this.

Code: Select all

		struct Tester
		{
			Tester(int) {}  // No default constructor
			void dummy() {}
		};
		typedef void (Tester::*unspecified_bool_type)();
		operator unspecified_bool_type() const
		{
			return pRep == 0 ? 0 : &Tester::dummy;
		}

		//static void unspecified_bool( SharedPtr*** )
		//{
		//}

		//typedef void (*unspecified_bool_type)( SharedPtr*** );

		//operator unspecified_bool_type() const
		//{
		//    return pRep == 0 ? 0 : &unspecified_bool;
		//}

Ogre::SharedPtr a(new int);
// here not warning at msvc.
if(a)
{
// a is not empty.
}

[Ybalrid]

Isn't this expected behavior?

It's standard practice in C/C++ to test pointers if they are "NULL" or not.

if(pointer) is equivalent to testing if(pointer != 0). (NULL is a #define that has the value 0)

You'll get the same result with the C++ standard std::shared_ptr<> (available since C++11,) or the one from boost.

[paroj]

this is about a (stupid) MSVC warning:
https://msdn.microsoft.com/en-us/librar ... s.90).aspx

[Ybalrid]

Oh, stupid indeed. I didn't even catch this was the actual problem discussed by the OP.

Speaking of stupid :

Casting the expression to type bool will not disable the warning, which is by design

What? they really want you to force you to write "!= 0" so that the assigned result is inherently of type bool?