Minor issues with the Ogre API that can be trivial to fix
-
dermont
- Bugbear
- Posts: 812
- Joined: Thu Dec 09, 2004 2:51 am
- x 42
Post
by dermont »
Cut and paste typo in OgreGpuProgramParams.cpp -> GpuNamedConstantsSerializer::exportNamedConstants
Code: Select all
OGRE_EXCEPT(Exception::ERR_CANNOT_WRITE_TO_FILE,
"Unable to write to stream " + stream->getName(),
// "GpuNamedConstantsSerializer::exportSkeleton");
"GpuNamedConstantsSerializer::exportNamedConstants");
-
sercero
- Bronze Sponsor
- Posts: 477
- Joined: Sun Jan 18, 2015 4:20 pm
- Location: Buenos Aires, Argentina
- x 165
Post
by sercero »
This still exists in the latest version of OGRE:
https://github.com/OGRECave/ogre/blob/m ... Params.cpp
Code: Select all
void GpuNamedConstantsSerializer::exportNamedConstants(
const GpuNamedConstants* pConsts, DataStreamPtr stream, Endian endianMode)
{
// Decide on endian mode
determineEndianness(endianMode);
mStream =stream;
if (!stream->isWriteable())
{
OGRE_EXCEPT(Exception::ERR_CANNOT_WRITE_TO_FILE,
"Unable to write to stream " + stream->getName(),
"GpuNamedConstantsSerializer::exportSkeleton");
}
Is it a bug?
It seems so.
-
paroj
- OGRE Team Member
- Posts: 2087
- Joined: Sun Mar 30, 2014 2:51 pm
- x 1127
Post
by paroj »
feel free to create a pull request for this