[2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material Topic is solved

Discussion area about developing with Ogre2 branches (2.1, 2.2 and beyond)
Post Reply
rujialiu
Goblin
Posts: 230
Joined: Mon May 09, 2016 8:21 am
x 24

[2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Post by rujialiu » Fri Feb 22, 2019 3:03 pm

Hi!

With a material with FLAG_SPERATE_DIFFUSE_FRESNEL, if hlms piece BRDF_EnvMap is used, shader will fail to compile because piece getDiffuseFresnelWithRoughness used NdotL, but the definition of NdotL is commented at the beginning of @piece BRDF_EnvMap. It looks like uncommenting that line will not cause other problems?

Thanks!
0 x

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 4106
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 242
Contact:

Re: [2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Post by dark_sylinc » Fri Feb 22, 2019 5:00 pm

Hi!

I remember I commented it because I saw NdotL was not being used. Obviously, I saw wrong.

Thanks for the report!
0 x

rujialiu
Goblin
Posts: 230
Joined: Mon May 09, 2016 8:21 am
x 24

Re: [2.2] Shader compilation failed with FLAG_SPERATE_DIFFUSE_FRESNEL material

Post by rujialiu » Sun Feb 24, 2019 3:21 am

dark_sylinc wrote:
Fri Feb 22, 2019 5:00 pm
Thanks for the report!
Thanks for the fix!
0 x

Post Reply