Storing PFG_R16_UNORM Texture crash

[Lax]

Hi,

I don't know, it this is already fixed, but when I try to store a texture with the format PFG_R16_UNORM . I get a Heap corruption crash in FreeImage.
When I store a texture in PFG_R8_UNORM format, it does not crash and a valid texture will be stored.

I tested it in terra, in the function "createHeightmap".

Code: Select all

m_heightMapTex->writeContentsToFile("path/TestHeightMap.png", 0, m_heightMapTex->getNumMipmaps());

Best Regards
Lax

[Eugene]

Thank you for reporting, fixed.

[Lax]

Ok thanks, now it works.

[Lax]

Hi Eugene,

I found another strange behavior.
When I store a PFG_RGBA8_UNORM image, internally the format:
from PFG_RGBA8_UNORM
to PFG_BGRA8_UNORM

Which causes errors when loading, since the rgba has been swapped. I found out, that it happens during "writeContentsToFile" in "OgreFreeImageCodec2.cpp":

Code: Select all

        case PFG_RGBA8_UNORM:
        case PFG_RGBA8_UNORM_SRGB:
        case PFG_RGBA8_UINT:
        case PFG_RGBA8_SNORM:
        case PFG_RGBA8_SINT:
#if FREEIMAGE_COLORORDER == FREEIMAGE_COLORORDER_BGR
            // typeless RGBA => BGRA conversion
            origFormat = PFG_RGBA8_UNORM;
            supportedFormat = PFG_BGRA8_UNORM;
#else
            // typeless RGBA => RGBA conversion
            origFormat = PFG_RGBA8_UNORM;
            supportedFormat = PFG_RGBA8_UNORM;
#endif

I have no idea why FREEIMAGE_COLORORDER_BGR is defined? Is this on purpose?

Best Regards
Lax