Vulkan broken on v3-0 branch

Discussion area about developing with Ogre-Next (2.1, 2.2 and beyond)


Nucleartree
Kobold
Posts: 39
Joined: Tue Apr 04, 2017 9:10 pm
Location: Cardiff, UK
x 21

Vulkan broken on v3-0 branch

Post by Nucleartree »

Hi everyone,

This would've been a github ticket but I thought this would be easier. My CICD build is refusing to compile Vulkan on the v3-0 branch as of a change 3 days ago.

https://github.com/OGRECave/ogre-next/c ... 5f6a37acc9

Code: Select all

[ 58%] Building CXX object PlugIns/ParticleFX/CMakeFiles/Plugin_ParticleFX.dir/src/OgreBoxEmitter.cpp.o
/home/runner/build/ogre2/RenderSystems/Vulkan/src/OgreVulkanAsyncTextureTicket.cpp: In member function ‘virtual void Ogre::VulkanAsyncTextureTicket::downloadFromGpu(Ogre::TextureGpu*, Ogre::uint8, bool, Ogre::TextureBox*)’:
/home/runner/build/ogre2/RenderSystems/Vulkan/src/OgreVulkanAsyncTextureTicket.cpp:152:47: error: ‘class Ogre::VulkanQueue’ has no member named ‘getCurrentCmdBuffer’; did you mean ‘mCurrentCmdBuffer’?
  152 |                 vkCmdPipelineBarrier( mQueue->getCurrentCmdBuffer(),
      |                                               ^~~~~~~~~~~~~~~~~~~
      |                                               mCurrentCmdBuffer

Looks like this change was cherry picked onto the v3-0 branch but getCurrentCmdBuffer is only available on the master branch, the convention in 3-0 is just direct access. Ogre's CICD didn't pick that up because buildLinux looks like it's only building for master.

Thanks!

Platform: Ubuntu 24.04, GCC, github cloud runner.

User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 5576
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 1411

Re: Vulkan broken on v3-0 branch

Post by dark_sylinc »

I thought we had CI to pick up on this stuff, but I see it's not properly set up. Thanks for reporting!