Vector3 weird assignment..

[syedhs]

Someone should fix this:-

Code: Select all

Vector3 test;
test = true;

It compiles in Visual 2005 without even a warning..

[so0os]

that's explicit consturctors.

it goes like this

Code: Select all

Vector3 << float << int << bool

[syedhs]

Yeah but that can potentially introduce tricky bug to one's app - mine is one of them For an example:-

Code: Select all

bool mHasPosition;
Vector3 mPosition;
...
mPosition = true; // it should be mHasPosition = true;

And btw, what is the use of statement Vector3 v = 1? It was probably done to ease some assignments, but I think it doesn't look right.

[so0os]

I guess you're right, there's no need for explicit constructor from a single float. Probably no one uses it anyways.

[Klaim]

Code: Select all

inline explicit Vector3( const Real scaler )

inline Vector3& operator = ( const Real fScaler )

So the idea is to provide a way to build a scaling vector in one line, i guess. Is it widely used in the Ogre code?


Anyway, the operator= version is dangerous, while the constructor seems useful. Only the operator should be removed?